LemmyNet / lemmy

🐀 A link aggregator and forum for the fediverse
https://join-lemmy.org
GNU Affero General Public License v3.0
13.12k stars 863 forks source link

Remove Person from CommunityBlockView/PersonBlockView/InstanceBlockView #4793

Open MV-GH opened 3 months ago

MV-GH commented 3 months ago

Requirements

Is your proposal related to a problem?

Person in Instance/Person/CommunityBlockView is not needed at all.

Person can already be found within the same response at $.my_user.local_user_view.person It is unnecessary duplicated at $.my_user.instance_blocks[*].person and $.my_user.community_blocks[*].person and $.my_user.community_blocks[*].person

Describe the solution you'd like.

Remove it

Describe alternatives you've considered.

None

Additional context

No response

dessalines commented 2 months ago

Going into those structs, I wonder if any are really necessary now. Just returning the Community, TargetPerson, or Instance should be enough.

MV-GH commented 2 months ago

Yeah they aren't necessary in Jerboa I just map em to those. (All though I don't mind if you keep the wrapper)