[Bug]: API responds extremely slowly to `post/list` request under certain conditions - Githubissues

LemmyNet / lemmy

🐀 A link aggregator and forum for the fediverse

https://join-lemmy.org

GNU Affero General Public License v3.0

13.25k stars 880 forks source link

[Bug]: API responds extremely slowly to `post/list` request under certain conditions #5136

Open Sjmarf opened 2 weeks ago

Sjmarf commented 2 weeks ago

Requirements

[X] Is this a bug report? For questions or discussions use https://lemmy.ml/c/lemmy_support
[X] Did you check to see if this issue already exists?
[X] Is this only a single bug? Do not put multiple bugs in one issue.
[X] Do you agree to follow the rules in our Code of Conduct?
[X] Is this a backend issue? Use the lemmy-ui repo for UI / frontend issues.

Summary

This only happens in a very specific edge case circumstance so isn't a critical issue. It takes ~20 seconds to perform the post/list request.

Steps to Reproduce

Log into an account that has <50 posts in the "moderator view" feed.
Go to api/v3/post/list?type_=ModeratorView&limit=50&page=1
Copy the next_page value from the response to clipboard
Go to api/v3/post/list?type_=ModeratorView&limit=50&page_cursor=%s. Replace %s with the string you copied in the previous step.
Observe that it takes ~20s for Lemmy to return the correct response (which is { "posts": [] })

Technical Details

I can't reproduce this issue by using the page parameter so it's possibly related to the cursor system

Lemmy Instance

Tested on lemmy.ml (0.19.6-beta.1) and sh.itjust.works (0.19.5)

dessalines commented 1 week ago

Could be really difficult to add indexes for that query. Would really be helpful if we had some more DB experts to help with these.