Lemon-King / ToS-LKChat

Tree of Savior Chat Addon
36 stars 8 forks source link

Critical bug. #8

Closed Dalamar6 closed 8 years ago

Dalamar6 commented 8 years ago

If you spam wasdawdasdaw or whatever from the trashbad chat system's failness, the addon blocks and reports yourself, resulting in a crash, and you can no longer log in with the addon installed.

Addon should clearly ignore yourself and party members. Also, it's too sensitive.

Lemon-King commented 8 years ago

Do you have a copy of the line you typed? Or at least a close example?

Dalamar6 commented 8 years ago

That was the example, I use wasd to move. I don't have the exact line, it was last night.

Lemon-King commented 8 years ago

Could you try getting me a repo case? I've also updated my development copy to ignore the player, for some reason that wasn't checked.

Dalamar6 commented 8 years ago

What do you mean repo case? By the way that crash also hit my friend last night when I hit enter, he crashed exactly when I did and had to delete the addon too, so I think it's not just the player.

Lemon-King commented 8 years ago

A reproduction case, where you can reproduce the bug more than once under the same or different conditions. So a few more things I'll need if I want to repo it on my end. Were you in a dungeon or world zone? How big was your group? Did you put the message in say (normal), party, guild, whisper (group whisper), shout?

Dalamar6 commented 8 years ago

Starter area messing with the dysfunctional keybind system, chatting with a friend (in friendlist) in a 2 man party chat. 0.4a, also have betterquest and tos-lua-addons-excrulon-20160411-02 if those matter.

How would I reset lkchat's data so I can log in with it installed again btw?

Lemon-King commented 8 years ago

Question, where does the client crash when you try to log in? What screens do you get past?

Dalamar6 commented 8 years ago

It was crashing last night after selecting a character. Works today with lkchat installed oddly.

Lemon-King commented 8 years ago

That is odd, well I pushed a new version (v0.4b) which has a check in place for character name.

Thanks for all the reports, feel free to PM me on the TOS forums.