LemonBoy / bar

A featherweight, lemon-scented, bar based on xcb
MIT License
1.62k stars 193 forks source link

XBM icon support #79

Open rootcoma opened 10 years ago

rootcoma commented 10 years ago

Are you interested in supporting xbm icons?

The biggest problem I see is adding another 300 lines of code, and dependency for xcb_image.

I have created a branch with functioning xbm support, however I do not feel that it is ready for a PR. The code could use testing and some improvements to xbm support and string handling. If anyone has suggestions let me know.

rootcoma/bar@20436556ce0fc5ceda319b3692ca58e6e2e3ed16

The syntax is

%{I<filename>} eg %{Iicons/clock.xbm}
LemonBoy commented 10 years ago

The reason that made me not implement this earlier (I had a big collection of xbm icons back then) was the shitload of code required to support those :< However I see the code is well commented and ifdef shielded, I still have to think whether a dwm-like approach (having a list of patches for the user to apply) might work for bar too to keep the core lean)

CamilleScholtz commented 9 years ago

I made a patch that works with the latest git version if anyone's interested: https://github.com/6c37/crux-ports/blob/master/bar-xbm/xbm.patch

wfdewith commented 9 years ago

I would really like to try bar, but I am still stuck with dzen2 because of my xbm icons. Any updates @LemonBoy?

LemonBoy commented 9 years ago

If there's enough demand for such an option I'd be happy to include it, I had myself quite a huge stash of xbm icons but then switched to the artwiz font and never bothered to look back :)

Bfgeshka commented 9 years ago

It wound be great, because in this case people would be able to use much more fonts in bar instead of only iconic ones now.

LemonBoy commented 9 years ago

I've put together some nice (?) code that doesn't depend on xcb_image and works fine with the upcoming gradient-background support :D Please ping me back if you don't get any news sometimes soon, I tend to forget about stuff :<

CamilleScholtz commented 9 years ago

ping~

Will this be merged into master any time soon?

LemonBoy commented 9 years ago

yep, but #105 is a blocker

darvelo commented 9 years ago

Image-based icons would be great.. would be nice to write a local weather script for bar someday. :)

jangel88 commented 9 years ago

@LemonBoy Ping! Looks like https://github.com/LemonBoy/bar/issues/105 was fixed. Any chance to get this issue resolved now?

CamilleScholtz commented 9 years ago

ping3 :p

What @jangel88 said.

LemonBoy commented 9 years ago

I'll try to give a shot this weekend, I'm super busy lately and I'm also trying to come up with a cairo/pango version of bar that will (eventually) replace this :)

@onodera-punpun I definitely love your avatar :3

LemonBoy commented 9 years ago

A quick heads up, I haven't finished implementing this at the moment, but someone created a nice font that includes a lot of icons [1], you should check it out!

[1] https://github.com/gstk/siji

eigengrau commented 9 years ago

Glyphicons also make for nice eye candy in the bar :)

ycny commented 9 years ago

@LemonBoy are you still working on this? :)

hacktivateit commented 8 years ago

ping @LemonBoy