search

LemonBoy / bar

A featherweight, lemon-scented, bar based on xcb
MIT License
1.63k stars 194 forks source link

Font selection #98

Closed flannelhead closed 9 years ago

flannelhead commented 9 years ago

This PR adds the ability to change the font used to draw the following characters. The fonts can be selected with %{Ti}, where index is a zero-based index of the font list supplied to bar. Bar can be reset to the default fallback behaviour by giving any non-index, for example %{T-}. It will also fall back if the current character can't be drawn with the selected font.

LemonBoy commented 9 years ago

I've briefly reviewed this PR and it looks pretty much ok to me :) There are just a few nitpicks here and there

flannelhead commented 9 years ago

I've now addressed your fix suggestions. Thanks for the valuable feedback on the code (I'm still just learning C).

LemonBoy commented 9 years ago

This is great! :D sorry for being so picky, I'm merging this as soon as you fix the last note and squash all the commits :+1:

flannelhead commented 9 years ago

Done. Do you think it's OK now?

This also seems to close https://github.com/LemonBoy/bar/issues/90

LemonBoy commented 9 years ago

Aye, thanks for contributing :)