search

LemonUIbyLemon / LemonUI

LemonUI for .NET (FiveM, RageMP, RagePluginHook and ScriptHookVDotNet 3)
MIT License
177 stars 40 forks source link

Add support for ScriptHookVDotNetCore #101

Closed Sardelka9515 closed 10 months ago

Sardelka9515 commented 1 year ago

Nothing need to be changed since it shares identical scripting API with SHVDN.

Works perfectly, at least in my testing

justalemon commented 1 year ago

GitHub is being stupid and is not allowing me to update the branch.

Please merge master onto the PR so it can actually try and build with .NET 7 on CI

justalemon commented 1 year ago

Turns out, I forgot to change the build .NET version. Whops.

Can you merge master again? Thanks!

Sardelka9515 commented 1 year ago

No problem

justalemon commented 1 year ago

Looks like it copies the SHVDNCore DLL to the output directory. Could you please change that?

You could take a look at the SHVDN3 csproj if you are not sure how to do it :)

image

justalemon commented 1 year ago

Also, I don't think that the deps.json is required. That can be disabled with:

<GenerateDependencyFile>false</GenerateDependencyFile>
Sardelka9515 commented 1 year ago

Done. Do i need to squash this to one commit?

justalemon commented 1 year ago

Sure

justalemon commented 1 year ago

Just letting you know: There is nothing wrong with this PR, I just want to do some stuff before I merge and release :)

Sardelka9515 commented 1 year ago

Sure, no porblem 🙆‍♂️

Sardelka9515 commented 1 year ago

Closing this to avoid confusion as SHVDNC might get merged into SHVDN itself in the future

justalemon commented 1 year ago

I have been following the issues on the SHVDN repo.

Can you keep this around while .NET Core support is fully implemented? So i can do some testing locally and prepare for the Core version.

justalemon commented 1 year ago

So, it was decided in scripthookvdotnet/scripthookvdotnet#1036 that Core/5+ support will not be added to the existing version of SHVDN.

@Sardelka9515 do you plan to keep working on the core version in your repo?

Sardelka9515 commented 1 year ago

The core version can be maintained with minimum efforts (I can easily merge the the SHVDN upstream code at anytime) it currently have some issues with exception handling when running alongside SHVDN. it was resolved in scripthookvdotnet#1167 but the new version is not released yet. Maybe kagikn will make another version for .NET Core in the future but SHVDNC should work fine for now

I'm currently not very active in GTAV modding, so feel free to close this if you want.