search

LemonUIbyLemon / LemonUI

LemonUI for .NET (FiveM, RageMP, RagePluginHook and ScriptHookVDotNet 3)
MIT License
177 stars 40 forks source link

SET_TEXT_DROPSHADOW does the same thing as SET_TEXT_DROP_SHADOW #174

Closed justalemon closed 3 months ago

justalemon commented 3 months ago

I noticed this issue now, but you assumed wrong. SET_TEXT_DROPSHADOW just does the same thing as SET_TEXT_DROP_SHADOW unless a non-positive value is passed as the 1st argument. The 2nd to 5th argument is marked as UNUSED_PARAM in commands_hud.cpp and the native implementation doesn't even use none of them. If the 1st arg is not positive, the drop shadows is removed for the next text draw.

I wish I noticed the wrong assumption before releasing any stable releases tbh...

Originally posted by @kagikn in https://github.com/LemonUIbyLemon/LemonUI/issues/169#issuecomment-2129468723

justalemon commented 3 months ago

This commit has been reverted in e97053dc25b53380ac426940f328b549648bfa9e and all 2.1 releases have been pulled.