LemonUIbyLemon / LemonUI

LemonUI for .NET (FiveM, RageMP, RagePluginHook and ScriptHookVDotNet 3)
MIT License
177 stars 40 forks source link

Update BaseScaleform.cs #92

Closed TheOfficialDroid closed 1 year ago

TheOfficialDroid commented 2 years ago

Corrected invalid native call for RageMP and changed native invoker calls to their respective class functions, for better reference to the RageMP wiki

See https://github.com/LemonUIbyLemon/LemonUI/issues/91

justalemon commented 2 years ago

Any specific reason for changing the way that natives are called?

TheOfficialDroid commented 2 years ago

Any specific reason for changing the way that natives are called?

better reference to the RageMP wiki

Even if said wiki is marginally incomplete; Most people are directed towards it and very few have a clue how to use the invoker to begin with; Personal preference, if you'd prefer I can reverse them back to native invocation with the correct params.

justalemon commented 2 years ago

You should not use dynamic, as you don't know the type of return object during compilation.

TheOfficialDroid commented 2 years ago

You should not use dynamic, as you don't know the type of return object during compilation.

None of the changes implemented, use dynamic?

justalemon commented 1 year ago

Superseded by 80da07b47c834a98c3c4ee2b4c5d728a1ddae460