Lemoncode / lc-validation-summary

Angular directive for providing a validation summary to angular based forms.

11 stars 3 forks source link

Update to latest AngularJS version #47

Open arp82 opened 9 years ago

arp82 commented 9 years ago

It does not seem to work correctly when using AngularJS 1.3.14. For example, the plunker for sample 2 (http://plnkr.co/edit/AzMzQs?p=preview), when replacing the script reference for angularJS with the application does not remove the error message correctly.

RosanaRufer commented 9 years ago

:smile: Will start researching ASAP!

brauliodiez commented 8 years ago

Wokr in progress branch

https://github.com/Lemoncode/lc-validation-summary/tree/fix_angular_greater_than_1.3

brauliodiez commented 8 years ago

Pull request

49

brauliodiez commented 8 years ago

Merged. Please @nasdan check master status and current version published in bower, this patch it's a minor update, please propose new version number in this threas

nasdan commented 8 years ago

The current version in bower is v0.2.2 :

0.2 when we including unit tests
0.2.1 including build
o.2.2 rename ng to lc

This version will be v0.3, what do you think?

brauliodiez commented 8 years ago

Let's follow semver, it's a patch and does not introduce breaking changes, it should be 0.2.3

nasdan commented 8 years ago

Ready, new version published v0.2.3