Lemoncode / react-by-sample

Set of basic React + Typescript guided samples, cover basic principles of this technology.
MIT License
201 stars 81 forks source link

Error: Cannot find module 'extract-text-webpack-plugin' #62

Closed nikican closed 7 years ago

nikican commented 7 years ago

When I follow instructions I get the following error: `module.js:472 throw err; ^

Error: Cannot find module 'extract-text-webpack-plugin'`

'extract-text-webpack-plugin' is not in the list of plugins in this part of the guide: npm install css-loader style-loader file-loader url-loader html-webpack-plugin awesome-typescript-loader --save-dev

brauliodiez commented 7 years ago

Hi @nikican in which sample you get this error? (there must be a missing npm install extract-text-webpack-plugin in the readme, or a require('extract-text-plugin') in the wepback.config, if you can provide me the details sample and where I can jump on that and fix the guide (or if you want to fork it and fix it please feel free).

Thanks

nikican commented 7 years ago

Hi @brauliodiez Sorry, I should have formulated the issue a bit better.

It happens when I follow instructions for 00 Boilerplate.

In readme.md file there is a line: npm install css-loader style-loader file-loader url-loader html-webpack-plugin awesome-typescript-loader --save-dev and 'extract-text-webpack-plugin' is not in that list which causes the above mentioned error.

brauliodiez commented 7 years ago

Just updating the readme step to this would fix the issue?

npm install css-loader style-loader file-loader url-loader html-webpack-plugin awesome-typescript-loader -extract-text-webpack-plugin --save-dev

If you can confirm that's the case, I can update the guide, or if you wish you can fork and do it (as you preffer).

Thanks

brauliodiez commented 7 years ago

Hi @nikican, @mjuanfe have just uploaded a fix, merged :-). Thanks for your help.