search

Lemoncode / simplechart

Simplechart seed
MIT License
12 stars 13 forks source link

#12 Inital plumbing / architecture #14

Closed ebarriosara closed 6 years ago

ebarriosara commented 6 years ago

Same configuration as in https://github.com/Lemoncode/react-simple-testing/tree/master/00%20Boilerplate has been done, except for the testing configuration, that has been followed from https://github.com/Lemoncode/redux-by-sample/tree/master/11%20Testing_Jest because the first one was using karma, mocha, sinon, etc. instead of just jest and enzyme like the second one.

Apart from that, there are some other dependencies that have not been added because it is not sure that we will need them. They are: bootstrap, jquery, lc-form-validation and toastr.

Regarding webpack files, common.js has not been created because we won't have a test folder for webpack. Instead, we will only have one webpack folder with base.js, dev.js and prod.js.

Please, let me know if something else should be changed, added or removed. Thanks.

brauliodiez commented 6 years ago

Good stuff, next step it to add routing, here we will add version 3 of react-router (@Nasdan can provide you more detail about this), version 4 still doesn't integrate seamlessly with redux in case we need it.

ebarriosara commented 6 years ago

Thanks for the review.

All issues, except for the .env one, have been committed in #17.

Regarding .env file, we need to clarify what to do, because we are using those variables in start:prod and build:prod scripts in package.json.