Closed crsanti closed 8 years ago
Thanks Santi,
Goot catches, @datencia is working on this sample, some of them we detected in the call we had some days ago (failure from our side we should had created issues on that), but there are some other details you are mentioning, that we are missing. @datencia can you go through the bullet points mentioned by @crsanti. Thanks :-).
You can review the progress of that update in the pull request #17
Totally agree on the optional point, this style helps when reading the doc, we can follow this proposal.
Thanks for your feedback, I'm going to open a new issue, assigning one of the samples readme to let jump on that.
hi!
I'm working on it right now. About the optional point that @crsanti mentioned, it's actually included in the pull request #17 .
Thanks for your feedback.
Pull request #17 merged
There are some issues I've encountered when making this sample:
studens.js
but no name is specified when creating webpack conf file (webpack.conf.js
) or HTML file (index.html
).node_modules/.bin/webpack
.webpack
from the command line insidebundle.js
thestudents.js
code is not transpilled to ES5. Babel needs to load the es2015 preset using .babelrc or query in webpack.conf.js:webpack.conf.js
the code is not transpilled. The test pattern needs to change from/\.es6$/
to/\.js$/
:code
or some kind stylish to file names and packages? E.g: We will write es6 code but we need to transpile it to es5, in order to do that we will installbabel-core plus
babe-preset-es2015
and save it as a dev dependency on thepackage.json
that has been generated by the npm init command we have created. Now we are going to create a js file calledstudents.js
that will include ES6 syntax.