Lemoncode / webpack-1.x-by-sample

Learn webpack 1.x by sample
http://www.lemoncode.net/
MIT License
27 stars 17 forks source link

00 Intro/00 BoilerPlate/ Documentation and steps to reproduce #18

Closed crsanti closed 8 years ago

crsanti commented 8 years ago

There are some issues I've encountered when making this sample:

brauliodiez commented 8 years ago

Thanks Santi,

Goot catches, @datencia is working on this sample, some of them we detected in the call we had some days ago (failure from our side we should had created issues on that), but there are some other details you are mentioning, that we are missing. @datencia can you go through the bullet points mentioned by @crsanti. Thanks :-).

You can review the progress of that update in the pull request #17

Totally agree on the optional point, this style helps when reading the doc, we can follow this proposal.

Thanks for your feedback, I'm going to open a new issue, assigning one of the samples readme to let jump on that.

datencia commented 8 years ago

hi!

I'm working on it right now. About the optional point that @crsanti mentioned, it's actually included in the pull request #17 .

Thanks for your feedback.

brauliodiez commented 8 years ago

Pull request #17 merged