Lemoncode / webpack-1.x-by-sample

Learn webpack 1.x by sample
http://www.lemoncode.net/
MIT License
27 stars 17 forks source link

Getting different errors when running eslint #56

Closed datencia closed 7 years ago

datencia commented 7 years ago

Hi,

Following the step guide 04 Misc / 01 Linting I've found the next issue. After running the command npm run lint the first time, ESLint throws three errors instead of two as described in the README.md.

eslint_output

As we can see, ESLint process the file webpack.config.js as well instead of ignore it. To solve this, we can tell ESLint to ignore files and directories. Consider to include this in the step guide.

thx

brauliodiez commented 7 years ago

Good catch, can you create a branch, add the ignore and update readme? Thanks

datencia commented 7 years ago

yep

linuxonrails commented 7 years ago

I think this issue should be closed but I can not do it.