Lemonszz / Biome-Makeover

MIT License
28 stars 33 forks source link

Slime- / Honey Blocks in the 1.18.1-1.4.8 Version are bugged #161

Closed Smuthytrinker closed 2 years ago

Smuthytrinker commented 2 years ago

Hey hey, Slime/Honey Blocks don't work correctly on the 1.18.1-1.4.8 Version of this mod.

Bug (with Biom-Makeover) dddddddddddddddddd

How it should work dddddddddddddddddd2

With this bug it's Impossible to make complex Sticky block contractions. Is there a way to fix that?

Lemonszz commented 2 years ago

We're no longer supporting 1.18.1.

I can't recreate this in 1.18.2 either. BM doesn't touch anything to do with honey or slime blocks, are you sure this is a BM issue and not some other mod?

Smuthytrinker commented 2 years ago

Yes its 100% an BM issue. Its when sticky blocks are attatch to each others + some random moveble blocks. We found some files in the 18.1 Mod code for Sticky blocks aswell as pistons. Maybe that changed something?

Lemonszz commented 2 years ago

Can you link me to this code?

Smuthytrinker commented 2 years ago
  1. biomemakeover-FABRIC-1.18.1-1.4.8.jar\META-INF\jars\MoreTags-2.0.3.jar\net\gudenau\minecraft\moretags\mixins\stickyblocks\PistonHandlerMixin.class

  2. biomemakeover-FABRIC-1.18.1-1.4.8.jar\META-INF\jars\MoreTags-2.0.3.jar\data\c\tags\blocks\sticky_blocks

Lemonszz commented 2 years ago

I see. Not caused by BM, but a dependency for that version. I'd report that here https://github.com/gudenau/minecraft-MoreTags

Kierecko commented 2 years ago

@Lemonszz wait but it's mentioned nowhere as dependency?

Lemonszz commented 2 years ago

It's included internally in some versions.

Kierecko commented 2 years ago

oh, okay, but how would we solve the issue then even if we reported it to more-tags and they changed something?

Lemonszz commented 2 years ago

Ideally, you'd update from 1.18.1 as we're not supporting it anymore.

If you open up the biome makeover .jar file in winrar/7zip then:

Kierecko commented 2 years ago

That's already super helpful and I hope we can make this work! Thanks for still responding so fast eventhough you don't support 1.18.1 anymore!