LemurPwned / VISM

Software for visualising magnetic layers
Other
6 stars 2 forks source link

Alter parsing handler #50

Closed LemurPwned closed 6 years ago

LemurPwned commented 6 years ago

Parsing functions should handle situation where there is no .odt file, more than one and single video file.

pawelkulig1 commented 6 years ago

Correct me if I am wrong: No .odt means we cannot plot 2D plot, all other widgets should work properly. How to handle more than one .odt file? User has to pick one? or give him ability to plot from 2 different sources?

LemurPwned commented 6 years ago

Yes: no .odt means no 2D plots (but all 3D plots should work, along 2D layer plot) handling more than one .odt file is right now done by raising an exception. This is invalid situation and we should not handle it otherwise. It appears that a single directory with .omf/.ovf files must have exactly one .odt file,that not being the case, raise an error. Allowing user to pick .odt file would cause the synchronisation problems since not all iterations would then match.

pawelkulig1 commented 6 years ago

If we pick one .odt/.txt file, then app should block 3D widgets. If we pick one .ovf/.omf file app should block plot because it doesn't make sense. (there is no data to plot) Is that correct?

LemurPwned commented 6 years ago

Not quite, If there is only one .odt file app should behave as it does right now, provided there are no .omf or .ovf files.

BUT if there is just one .ovf or .omf file and there is an .odt file then we should allow iterating only on plots. This is somehow conjugated with the issue of invalid data change on iteration.

pawelkulig1 commented 6 years ago

single odt, omf, ovf fixed on branch #53 waiting for merge.

LemurPwned commented 6 years ago

I will handle this if you dont mind i.e. the remaining bit with no odt or no txt