search

LemurPwned / VISM

Software for visualising magnetic layers
Other
6 stars 2 forks source link

Repick data #91

Closed pawelkulig1 closed 6 years ago

pawelkulig1 commented 6 years ago

Allows easily repick data. Fix:

88, #63

Creates:

89

Has:

90

pawelkulig1 commented 6 years ago

In my opinion ready to merge tbh.

LemurPwned commented 6 years ago

OK so I have an error which looks like that: btw is it necessary to add a dependency on glut?

screenshot from 2018-04-26 12-11-39

pawelkulig1 commented 6 years ago

I was testing and forgot to delete that, no new dependencies are required

pawelkulig1 commented 6 years ago

I will fix that a soon as I'm get back home

pawelkulig1 commented 6 years ago

Sorry for that now it seems to be cleaned.

LemurPwned commented 6 years ago

After prompting directory reselection follwing scenery :) appears and app crashes: screenshot from 2018-04-27 11-39-43

I will close for now until it is fully resolved ok? It might be a Linux specific problem so if you want I can take care of this.

pawelkulig1 commented 6 years ago

Crash is caused by None in regex, this is only GUI issue and has no impact on program.

LemurPwned commented 6 years ago

No, it does not. I havent even repicked I directory yet? It does not even prompt directory reselect window, just crashes. None in regex would raise an error (Attribtute or Value), in this case nothing is raised

pawelkulig1 commented 6 years ago

Ok I'll take a look.

pawelkulig1 commented 6 years ago

Please provide error log, I cannot reproduce it from your description. The only issue I found is connected with regex problem. Which as far as I am concerned is already fixed on your's branch.

LemurPwned commented 6 years ago

Ok so maybe check first and merge #85 and I will remerge master into this branch and try to reproduce the error. Btw I will enable logging because it sigkill by python, no error raised which indicated qt fault.

LemurPwned commented 6 years ago

I gave my "solution" to a problem on branch #repickDataFix User has to prompt reselection dialog again but at least no bug

pawelkulig1 commented 6 years ago

Check it now.

LemurPwned commented 6 years ago

You mean commit 163a61b5b1a07937d37ac36dc12125f42ee59c25 ? This does not fix the thing at all, it just changes Pop Up windows

pawelkulig1 commented 6 years ago

Please provide exact scenario when crash occurs, what data what options, what clicked, step by step.

LemurPwned commented 6 years ago
  1. Load any data
  2. Select any widget
  3. Click File-> load directory
  4. Crash (sigkill no err message)