Connection phase issue

[Luka234]

First of all - congrats on great addon!

Setup DSM 5.1-5004 Update 2 Download Station: 3.5-2638 SynoLoader: 1.2

Issue User that is not part of administrators group is unable to connect with SynoLoader preference 'DSM Version >= 4.1'.

Test case 1

• New synology user, part of users group, access to Download Station enabled, access to download folder granted.
• Logged in to DSM as new user and setup Download Station download folder

• Synoloader setup with 'DSM Version >= 4.1'

  Result: Synoloader unable to connect

  SynoLoader : try to conect to : http://192.168.88.2:5000
  SynoLoader : {"error":{"code":402},"success":false}

Test case 2

• same as Test case 1

• DSM user added to administrators group

  Result: Synoloader is working

  SynoLoader : try to conect to : http://192.168.88.2:5000
  SynoLoader : {"data":{"sid":"cLBF...400"},"success":true}
  
  SynoLoader : try to getall to : http://192.168.88.2:5000
  SynoLoader : try to getall to : http://192.168.88.2:5000
  SynoLoader : {"data":{"offeset":0,"tasks":[{"additional.............

Test case 3

• performed after sucessfull Test case 2

• DSM user removed from administrators group

  Result: SynoLoader is working (there is no connection phase, just getting data):

  SynoLoader : try to getall to : http://192.168.88.2:5000
  SynoLoader : {"data":{"offeset":0,"tasks":[{"additi..........

Test case 4 *performed after Test case 3

• restart Firefox

  Result: SynoLoader unable to connect (result same as Test case 1)

Test case 5

• SynoLoader setup with 'DSM Version < 4.1' Result: SynoLoader is working

  SynoLoader : Set Protocol to < DMS 4.1
  SynoLoader : try to conect to : http://192.168.88.2:5000
  SynoLoader : try to conect to : http://192.168.88.2:5000
  SynoLoader : {
   "id" : "ke0X1SaUz.SLs",
   "login_success" : true,
   "success" : true
  }
  
  SynoLoader : try to getall to : http://192.168.88.2:5000
  SynoLoader : try to getall to : http://192.168.88.2:5000
  SynoLoader : {
   "items" : [
      {
         "availablePieces" : 0,
         "connectedPeers" : 6,.............

[Lemutar]

Thanks for the great error report. I will analys this when return from my vacations.

[Luka234]

Hi, I think I've found problem. Minor changes in 'Protocol_API.js':

• change 'session=Synoloader' to 'session=DownloadStation'
• change all 'sid=' to '_sid='

According to Synology Download station API 20140326 this is how they should be. I'm very new to Synology API so I don't know did they change those param definitions.

[JeromeGillard]

Luka234's fix is working with my DSM Version >= 4.1. Thanks.