Lemutar / Synoloader

Firfox addon
18 stars 6 forks source link

fix API (session, sid) #8

Closed Luka234 closed 9 years ago

Luka234 commented 9 years ago

Sorry for second pull request - It is my first time:)

Minor changes in 'Protocol_API.js':

change 'session=Synoloader' to 'session=DownloadStation'
change all 'sid=' to '_sid='

According to Synology Download station API 20140326 this is how they should be. I'm very new to Synology API so I don't know did they change those param definitions.

With those changes my issue with connection is solved

Lemutar commented 9 years ago

Is it possible for you to fix the travis ci build test. My NAS wher the integrations test normaly run is offline. So you have to use a nother one.

Luka234 commented 9 years ago

I've setup NAS but travis ci build is failing. I'm new to this technology so having hard time tracing what is happening. New download task was created on NAS during test but test failed.

Lemutar commented 9 years ago

If you install the uxu addon witch i use for testing. You shoud be able to run the tests localy. Then finding the problem should be mutch easier. Am 19.12.2014 11:55 schrieb "Luka234" notifications@github.com:

I've setup NAS but travis ci build is failing. I'm new to this technology so having hard time tracing what is happening. New download task was created on NAS during test but test failed.

— Reply to this email directly or view it on GitHub https://github.com/Lemutar/Synoloader/pull/8#issuecomment-67571698.