search

LendingHome / zero_downtime_migrations

Zero downtime migrations with ActiveRecord 3+ and PostgreSQL
MIT License
561 stars 27 forks source link

Add cops to rubocop-migrations #7

Open sauloperez opened 7 years ago

sauloperez commented 7 years ago

Hi! I just came across this repo and I though it would be very interesting if we could integrate these rules into Rubocop so that we can have this checks together with all the other Rubocop cops. Besides, we could configure them per repo plus, autofix some, etc.

We started working on https://github.com/redbooth/rubocop-migrations not long ago so that we improve our practices in migrations. Also, it got integrated to Codeclimate https://github.com/codeclimate/codeclimate-rubocop/pull/74, so it integrates perfectly on our workflow (and possibly for others). We can add them as cops in here.

What do you think?

shuber commented 7 years ago

Nice, I'm all for integrating with Rubocop, that sounds pretty sweet! We don't have any immediate plans to work on porting to Rubocop but will happily accept PR's in the meantime if you or anyone else wants to take a crack at it. I'll leave this issue open for now, thanks for the suggestion!