LengoLabs / qbot

Qbot is an advanced, easy to setup, free, and unbranded Discord-Roblox ranking bot. If at any time during setting it up you need assistance, you can join the support server.
https://discord.gg/J47m7t4
MIT License
77 stars 138 forks source link

Added multiple Verification API Providers + QOL changes/bug fixes #104

Closed astranger1k closed 2 years ago

astranger1k commented 2 years ago

Added a configuration option to select a preferred API Provider Currently supporting:

Added a reference to the API used to fetch the user in /info

Added a .env.example file to show what Environment Variables to create

Corrected command registration behavior (random bug that cropped up)

Corrected a grammatical error in README.md

Refer to commits for changes.

yogurtsyum commented 2 years ago

I like the idea behind this PR but I've noticed some consistency issues with the rest of the bot's code. I will look into it more later and see if it is easier to accept this one and then make the changes, or redo the system.

Oji0721 commented 2 years ago

Good but if you ping someone its doesn’t work. ![Uploading 7A14275C-5C41-460B-8200-93F4273EA87C.jpeg…]()

sv-du commented 2 years ago

@Oji0721 That's an invalid image? Try uploading it again for OP to see it haha

Oji0721 commented 2 years ago

@zachariapopcorn https://gyazo.com/84992984e85f04a163db099ffe718f7d

astranger1k commented 2 years ago

Good but if you ping someone its doesn’t work. ![Uploading 7A14275C-5C41-460B-8200-93F4273EA87C.jpeg…]()

oddly enough, whenever I ran it before my changes it never worked anyway, regardless of the API used.

ill have a look later and append the changes to this

Oji0721 commented 2 years ago

Okay.

astranger1k commented 2 years ago

@yogurtsyum What needs doing to this PR before it is a viable solution?

yogurtsyum commented 2 years ago

In the configuration, you don't have a system to disable verification checks like before.

yogurtsyum commented 2 years ago

I've reverted this PR for a few reasons.

1) The styling of how you coded this really doesn't match what we used in Qbot. 2) Some of the QOL changes seemed unnecessary and actually might have broken certain things. 3) It appears some other features related to verification checks were deleted.

Thanks for the PR anyways.