LengoLabs / qbot

Qbot is an advanced, easy to setup, free, and unbranded Discord-Roblox ranking bot. If at any time during setting it up you need assistance, you can join the support server.
https://discord.gg/J47m7t4
MIT License
77 stars 138 forks source link

so i hate git (recreation of #101) #105

Closed brandonapt closed 2 years ago

brandonapt commented 2 years ago

lmao read the desc of #101

Oji0721 commented 2 years ago

Is this need a api on?

brandonapt commented 2 years ago

yes. are you trying to use this as your main bot? i advise against it as it is incomplete and stuff like the quota does not work yet

Oji0721 commented 2 years ago

So I need to use api and connect it to my game right?

brandonapt commented 2 years ago

yes, but i strongly advise against using this PR, as it is messy and currently unfinished.

brandonapt commented 2 years ago

now marking this as a draft---

lots of work needs to be done and will be done over the next few days to improve this

yogurtsyum commented 2 years ago

@brandoge91 When do you think this will be ready for review? Because I need to figure out if we are including this in 7.2 or the update after that.

brandonapt commented 2 years ago

hopefully by 1/10 (2 days), but maybe earlier

yogurtsyum commented 2 years ago

Anything I can do to help expedite this?

brandonapt commented 2 years ago

actually, this might be done in a few hours. i'm on a roll! the only thing i might need help with is testing.

brandonapt commented 2 years ago

this is done. you can review it whenever now

brandonapt commented 2 years ago

okay. i understand where you are coming from. will be recreated as a plugin PR and a API PR here

yogurtsyum commented 2 years ago

Not sure if you need to close this PR... just remove that one file.

brandonapt commented 2 years ago

oh, i understand what you meant now lol!

brandonapt commented 2 years ago

should now be good to merge (if i understand what u meant)

yogurtsyum commented 2 years ago

Actually... Do you think it would be best if instead of having references to activity in the actual bot, we just had a plugin for adding XP when a user is online for certain intervals?

brandonapt commented 2 years ago

sure, but what would we do about the quota? would that be a plugin? or just make it check XP?

yogurtsyum commented 2 years ago

Not sure to be honest... we could have our initial launch not include the quota system, and just allow adding XP based on activity through a plugin.

brandonapt commented 2 years ago

okay. ill put the quota system on the backburner for later, and ill make ingame xp a plugin

yogurtsyum commented 2 years ago

My goal is to have Qbot at its core just be a ranking bot, and have the power to install more tools that allow it to be a full ranking service. I think if we just had XP be a type of points system, and then had a plugin for applying this with activity, that would be received really well. What do you think?

brandonapt commented 2 years ago

seems like a great idea. i will keep all this stuff if we figure out a way to implement the quota as a plugin later, or we want any of it. i understand the purpose of qbot and i understand it :)))

yogurtsyum commented 2 years ago

Alright, for now I will close this pull request, but I look forward to seeing your Roblox activity tracking game as a plugin soon.