search

LengoLabs / qbot

Qbot is an advanced, easy to setup, free, and unbranded Discord-Roblox ranking bot. If at any time during setting it up you need assistance, you can join the support server.
https://discord.gg/J47m7t4
MIT License
77 stars 138 forks source link

Add page-based help menu support #107

Closed sv-du closed 2 years ago

sv-du commented 2 years ago

This adds the ability for the help command to have a "paging" system

I remember seeing this in the suggestions channel, so after when I was available to code it, I did

I wanted to still have support for the old method, but I was thinking on how I should implement it

I decided that in order to implement this feature, I did the following

Allow the help command accept an argument called "page-based", and if a value is given, the help embed is page based, else, it's regular Using reactions

There's no bugs as far as I know on this

Also, if you'd want me to implement it a different way (like it being a config value instead of the argument, or using buttons instead of reactions), just comment it below

Have a good day/night

brandonapt commented 2 years ago

dang it! I was going to make this! oh well, at least someone made this lol

sv-du commented 2 years ago

dang it! I was going to make this! oh well, at least someone made this lol

Lmao, it was really simple to make, took me around an hour to do and test

yogurtsyum commented 2 years ago

I feel like a pagination system like this should use components

sv-du commented 2 years ago

I feel like a pagination system like this should use components

I can do that right now if you want, as it's a few code changes

yogurtsyum commented 2 years ago

That'd be great, thanks. And remember that all messages should be from the locale file (so we can add multilingual support in the future), and that you use const when possible.

sv-du commented 2 years ago

Okay, I'll get to work on it, though also, I'll probably end up making it a config variable instead of a command argument, as now that I think about it, it just seems more clean

sv-du commented 2 years ago

@yogurtsyum Added requested changes, may you review?

yogurtsyum commented 2 years ago

This is showing up for me:

image

sv-du commented 2 years ago

It seems like it's conflicting with the group ban embeds from my last PR and these https://i.imgur.com/aHkL1wU.png

I haven't gotten an error like this before, so I'm really unsure on how I could fix it

sv-du commented 2 years ago

Well that failed

yogurtsyum commented 2 years ago

Do you see the resolve conflicts button or should I try it?

sv-du commented 2 years ago

I try it, but I just shows this

https://i.imgur.com/3XQgGOg.mp4

yogurtsyum commented 2 years ago

Hey, out of curiosity, why did you close this pull request?

sv-du commented 2 years ago

I'm going to remake the PR