search

LengoLabs / qbot

Qbot is an advanced, easy to setup, free, and unbranded Discord-Roblox ranking bot. If at any time during setting it up you need assistance, you can join the support server.
https://discord.gg/J47m7t4
MIT License
77 stars 138 forks source link

Multi-group support + dependency fixes #145

Open yogurtsyum opened 5 months ago

yogurtsyum commented 5 months ago

This pull request adds support for performing basic ranking actions on configured secondary groups. It also fixes issues with the got dependency saying it is not installed, even though it's Bloxy importing it.

Testing status

[M] - Multi-group actions [M] - Multi-group logging [P] - Multi-group verification checks [F] - Dependency bug fix

P = partially tested; M = mostly tested; F = fully tested.

Feedback needed

Broadly: does this do everything you would expect from multi-group functionality?

Specifically (non-exhaustive):

HyronHydel commented 5 months ago

Could verification checks be an option to be enabled for secondary groups as well?

yogurtsyum commented 5 months ago

Did some minimal testing, but could use someone with the whole proper Bloxlink + multi-group setup to test more thoroughly. Thanks for the feedback.

HyronHydel commented 5 months ago

This might be very specific, but could a bypass for verification checks be created for role ids as well?

vq9o commented 5 months ago

You should add permissions for specific groups. Doing some multi-group testing.

Jxkeyy commented 5 months ago

Verification Checks for seconary groups, making sure they cant accept / exile higher ranks or accepting if theyre not in the group at all

Jxkeyy commented 5 months ago

Comman to see all groupbans

vq9o commented 5 months ago

You should add permissions for specific groups. Doing some multi-group testing.

Started a draft for additional permissions per secondary group. -- Untested, nor completed. https://github.com/LengoLabs/qbot/compare/multigroup...vq9o:qbot:multigroup

Jxkeyy commented 5 months ago

logs showing what secondary group they got accepted into and if theyre being ranked what group it is

vq9o commented 5 months ago

You should add permissions for specific groups. Doing some multi-group testing.

Started a draft for additional permissions per secondary group. -- Untested, nor completed. multigroup...vq9o:qbot:multigroup

Update: Majority of the draft is completed with a re-write of multi-group. I have 2 issues to fix and testing to start before I submit a PR. https://github.com/vq9o/qbot/blob/multigroup/PR_INFO.md

yogurtsyum commented 5 months ago

logs showing what secondary group they got accepted into and if theyre being ranked what group it is

Only needs to be added to join requests. Already a feature for ranking.

yogurtsyum commented 5 months ago

@vq9o When your PR is ready, you can submit it to the multigroup branch here.