LengoLabs / qbot

Qbot is an advanced, easy to setup, free, and unbranded Discord-Roblox ranking bot. If at any time during setting it up you need assistance, you can join the support server.
https://discord.gg/J47m7t4
MIT License
77 stars 138 forks source link

Multigroup #147

Closed vq9o closed 5 months ago

vq9o commented 5 months ago

Changes

Forked from qbot/multi-group.

[!CAUTION] In this new version of qbot, previous data of XP & suspensions will be lost due to new DB structure.

Tests

Legend

Test results

[!CAUTION] XP & Suspension system un-tested.

Status

STABLE: YES

Contributors:

yogurtsyum commented 5 months ago

Can you document what these changes actually do?

yogurtsyum commented 5 months ago

I'm not sure what the first two bullet points under Changes mean. The third is not new--at least, it shouldn't be. This PR should be merged into my multigroup branch with just what you intended to make different, not be the PR for all of multi-group support into master in the first place.

As for the last bullet point, everything that changes needs to be mentioned in the PR so I know exactly what it is I am accepting--for both documentation purposes and quality assurance.

I think what you should do is resubmit this PR to LengoLabs:multigroup with a title that accurately describes what is different that you added (like permissions, if that's the main goal here). You should write a description that exhaustively covers everything changed, and document how it changes how people should use the bot. (It looks like there was a lot of stylistic changes to my code... why?)

That was a lot, so let me (Lengo) know if you have any questions on the Discord.