Closed mangeloni30 closed 1 year ago
Hey ! Thanks for the PR.
We need to make some changes in order to add this.
- First we should try to split the logic between the models. They behave differently, one returns texts and the other handles objects.
- For now let's keep it simple and let's keep the function
generatePrompt
returning a string for all models. So we can keep using the same UI for the prompt view.- We should add a select input in the config panel (where you configure your API KEY) to be able to switch between models. This parameter should be saved and handled in the same way that the API KEY is being handled.
- For the functions handling the "chat/completions" endpoint, we shouldn't be doing any spliiting on the responses like we do for the completions, since the texts are already split into roles.
Let me know if you have any doubts!
Hey ! Thanks for the PR.
We need to make some changes in order to add this.
- First we should try to split the logic between the models. They behave differently, one returns texts and the other handles objects.
- For now let's keep it simple and let's keep the function
generatePrompt
returning a string for all models. So we can keep using the same UI for the prompt view.- We should add a select input in the config panel (where you configure your API KEY) to be able to switch between models. This parameter should be saved and handled in the same way that the API KEY is being handled.
- For the functions handling the "chat/completions" endpoint, we shouldn't be doing any spliiting on the responses like we do for the completions, since the texts are already split into roles.
Let me know if you have any doubts!
Hi, I have pushed new changes regarding with your suggestions. Can you pls take a look on that?
Hey !
I added you a review, let's change those for a switch in the other file.
Hey JC, I have pushed more changes, this time the structure is different. Let me know how does this look to you.
Hi @apresmoi, I just added the following changes.
textDavinci003Completions
function to queryTextDavinci003Completions
gpt35TurboCompletions
function to queryGpt35TurboCompletions
queryCompletionsChat
function I have added a switch
statement to return the result directly. Hey thanks again for the PR and corrections. I tried it out and it seems to work as spected.
Merging this.
AI Data Dashboard