LennardF1989 / NiohResolution

NiohResolution adds support for any resolution to Nioh: Complete Edition on PC.
http://steamcommunity.com/app/485510/discussions/0/1485487749769597344/
62 stars 8 forks source link

Does not work on version 1.24.1 #15

Closed HBbrody closed 3 years ago

HBbrody commented 3 years ago

The new game patch 1.24.1 has broken the functionality. Could you please release a version compatible with the latest Nioh release?

Trokinos commented 3 years ago

Confirmed, i just tested this on the epic store version that is free this week and unfortunately the current NiohResolution does not work with this new 1.24.1 patch. Please, could you consider updating NiohResolution ?

ScratchMode commented 3 years ago

Lost function on the Steam version. Re-patching the exe failed too.

_Unpacking nioh.exe... File is packed with SteamStub Variant 3.1 (x64)! Step 1 - Read, decode and validate the SteamStub DRM header. Step 2 - Read, decode and process the payload data. --> File has payload data! Step 3 - Read, decode and dump the SteamDRMP.dll file. --> File has SteamDRMP.dll file! Step 4 - Handle .bind section. Find code section. --> .bind section was kept in the file. Step 5 - Read, decrypt and process code section. --> .text linked as main code section. --> .text section is encrypted. Step 6 - Rebuild and save the unpacked file. --> Unpacked file saved to disk! --> File Saved As: nioh.exe.unpacked.exe

Patching resolution to 3440x1440 with scale set to 1.0... -> Patching offset 8717317 -> Patching offset 19095332 -> PATTERN_MAGIC1 expected 1, but got 0!

Patching failed, consider restoring a backup and try again._

Packuh commented 3 years ago

Confirmed, i to tested on epic store version. current NiohResolution does not work with this new 1.24.1 patch.

Ted-Barrett commented 3 years ago

A temporary solution for me (I'm using epic games) is the following: 1) Set your resolution to the corresponding widescreen resolution (i.e: 2560x1440 for 3440x1440) 2) open nioh.exe with HxD and change C7 43 50 39 8E E3 3F to:

Basically this just changes the aspect ratio the game renders at, then in fullscreen it will be stretched to fill the whole screen. It's still techincally rendering at the lower (widescreen) resolution, but it's not super noticable, except when you try to take a screenshot it's squeezed.

Note that this only works for fullscreen mode, and the hud will be stretched. Also I haven't actually tested 2560x1080 but should work I think.

Vitzeno commented 3 years ago

I think I've got a fix on this pr.

I'm not a game dev and don't really know what I'm doing, so it would be nice for people to have a look and test it out, thanks.

NCProduction commented 3 years ago

@BarneyKB Thanks for the tip! But how do you calculate the hex value for other more exotic aspect ratio ? (for 2280x1080 as exemple)

p1xel8ted commented 3 years ago

The aforementioned fixes here don't appear to work as described on the Steam version. (Unpacked).

The new (Steam) EXE:

ScratchMode commented 3 years ago

Was able to get this to run normally again with Vitzeno's thread

I think I've got a fix on this pr.

However I am not a programmer so not sure how to make the exe work by itself so you all can use it like before. My visual studio build exe seems to only work in the confines of the build folder , I had to drag the nioh.exe over to be modified instead of dragging the NiohResolution.exe over to the Nioh install folder for modification there. So.... un-shareable

LennardF1989 commented 3 years ago

Working on this, will report back soon.

ScratchMode commented 3 years ago

This does appear to Work On EPIC Games Launcher version as well. Lennard you might want to add this option to your front page description

Demonstration below. EGS Vanilla 4k setting running on a 3440x1440 display Nioh Screenshot 2021 09 11 - 10 32 19 50

Updated with the latest pull Request from Vitzeno EGS with NiohResolution 4k setting running on a 3440X1440 display Nioh Screenshot 2021 09 11 - 10 35 25 16

LennardF1989 commented 3 years ago

Please see https://github.com/LennardF1989/NiohResolution/pull/16#issuecomment-917477562 and report findings :)