Todays release (1.0.7) broken?

Lennoard / SysctlGUI

A GUI application to edit Android kernel variables at runtime in a rooted environment

MIT License

72 stars 8 forks source link

Todays release (1.0.7) broken? #16

Closed IzzySoft closed 4 years ago

IzzySoft commented 4 years ago

Just wondering:

attached APK is named sysctlgui-v1.0.8.apk though tag suggests v1.0.7
apksigner complains the APK "does not verify" (did you forget to sign? Remember that v2 was only introduced with Android 7, so up to Android 6 v1 (JAR) signature is required).

$ apksigner verify --verbose sysctlgui-v1.0.8.apk 
DOES NOT VERIFY
ERROR: No JAR signatures
$ apksigner version
0.9

Can you please verify and replace the APK? Thanks!

Lennoard commented 4 years ago

I definitely messed up. One signature is missing. And the version name* is wrong that's why the release apk has 1.0.8 automatically added to it. I'll fix it as soon as I get back to my computer. I suppose it's ok to "downgrade" the version name as long as the version code is the same.

IzzySoft commented 4 years ago

Great, thanks a lot – looking forward to that!

PS: Hope you like this (DD GUI will show up in that list tomorrow, after the next sync). If you want to link there from your resp. Readmes, I can provide you with a fitting badge :smiley: Updates are pulled within 24h of your creating a new tag and attaching the APK to it, which is how this issue was brought to my attention (my updater sent me a complaint :rofl:)

Lennoard commented 4 years ago

APK replaced. Also check f1205dd for the version name and ae44101 for the badge

IzzySoft commented 4 years ago

Cool, thanks! Even placed the link to my repo first :heart_eyes: In this case I simply had to trigger a manual run: confirmed, indexed, syncing now – then wait for Brainstorm to announce it on IRC and Reddit :tada:

As it's definitely solved, I'm closing this issue. Oh, and DD GUI is available now as well, with the sync just finished :smiley: And there comes Brainstorm, announcement is out, yay! :raised_hands: