LennyPhoenix / GodotDiscordSDK

A Discord Game SDK wrapper for Godot, written in C.
MIT License
54 stars 5 forks source link

The game doesn't work without Discord #13

Closed WheatleyHDD closed 3 years ago

WheatleyHDD commented 3 years ago

Describe the bug

The game just doesn't start when Discord is closed

To Reproduce

  1. Close Discord
  2. Run the game

Additional context

I just used yours demo. I checked that CreateFlags has the value NoRequireDiscord. Debugger doesn't throw any errors. The game opens, the splash screen hangs, and after a small amount of time (5-10 seconds) the game window closes

JezSonic commented 3 years ago

Could you send there output logs (from console)?

WheatleyHDD commented 3 years ago

It's empty image

JezSonic commented 3 years ago

Are you on windows? If so, please send logs from system console that apperars with Godot

JezSonic commented 3 years ago

Also. Could you run Godot with --verbose argument for more logs? I can't open that project right now and you know... Logs would be very helpful. And what types of libraries do you use? Debug or Release? What version of Godot do you use?

WheatleyHDD commented 3 years ago

I'm use release libraries and latest stable Godot Engine version 3.2.3

That's log from console with --verbose

Godot Engine v3.2.3.stable.official - https://godotengine.org
Using GLES3 video driver
OpenGL ES 3.0 Renderer: GeForce GTX 1650 Ti/PCIe/SSE2
WASAPI: wFormatTag = 65534
WASAPI: nChannels = 2
WASAPI: nSamplesPerSec = 48000
WASAPI: nAvgBytesPerSec = 384000
WASAPI: nBlockAlign = 8
WASAPI: wBitsPerSample = 32
WASAPI: cbSize = 22
WASAPI: detected 2 channels
WASAPI: audio buffer frames: 1962 calculated latency: 44ms

CORE API HASH: 17947557007960061372
EDITOR API HASH: 513236543915789544
Loading resource: res://scripts/autoload/discord_manager.gd
Loading resource: res://discord_sdk/discord.gd
Loading resource: res://discord_sdk/core.gdns
Loading resource: res://discord_sdk/discord_game_sdk.gdnlib
Loading resource: res://discord_sdk/user.gdns
Loading resource: res://discord_sdk/user_manager.gdns
Loading resource: res://discord_sdk/image_dimensions.gdns
Loading resource: res://discord_sdk/image_handle.gdns
Loading resource: res://discord_sdk/image_manager.gdns
Loading resource: res://discord_sdk/activity_timestamps.gdns
Loading resource: res://discord_sdk/activity_assets.gdns
Loading resource: res://discord_sdk/party_size.gdns
Loading resource: res://discord_sdk/activity_party.gdns
Loading resource: res://discord_sdk/activity_secrets.gdns
Loading resource: res://discord_sdk/activity.gdns
Loading resource: res://discord_sdk/activity_manager.gdns
Loading resource: res://discord_sdk/presence.gdns
Loading resource: res://discord_sdk/relationship.gdns
Loading resource: res://discord_sdk/relationship_manager.gdns
Loading resource: res://discord_sdk/discord.gd
Loading resource: res://discord_sdk/user.gdns
Loading resource: res://discord_sdk/user_manager.gdns
Loading resource: res://discord_sdk/image_dimensions.gdns
Loading resource: res://discord_sdk/image_handle.gdns
Loading resource: res://discord_sdk/image_manager.gdns
Loading resource: res://discord_sdk/activity_timestamps.gdns
Loading resource: res://discord_sdk/activity_assets.gdns
Loading resource: res://discord_sdk/party_size.gdns
Loading resource: res://discord_sdk/activity_party.gdns
Loading resource: res://discord_sdk/activity_secrets.gdns
Loading resource: res://discord_sdk/activity.gdns
Loading resource: res://discord_sdk/activity_manager.gdns
Loading resource: res://discord_sdk/presence.gdns
Loading resource: res://discord_sdk/relationship.gdns
Loading resource: res://discord_sdk/relationship_manager.gdns
Loading resource: res://discord_sdk/discord.gd
Loading resource: res://discord_sdk/user.gdns
Loading resource: res://discord_sdk/image_dimensions.gdns
Loading resource: res://discord_sdk/image_handle.gdns
Loading resource: res://discord_sdk/image_manager.gdns
Loading resource: res://discord_sdk/activity_timestamps.gdns
Loading resource: res://discord_sdk/activity_assets.gdns
Loading resource: res://discord_sdk/party_size.gdns
Loading resource: res://discord_sdk/activity_party.gdns
Loading resource: res://discord_sdk/activity_secrets.gdns
Loading resource: res://discord_sdk/activity.gdns
Loading resource: res://discord_sdk/activity_manager.gdns
Loading resource: res://discord_sdk/presence.gdns
Loading resource: res://discord_sdk/relationship.gdns
Loading resource: res://discord_sdk/relationship_manager.gdns
Loading resource: res://discord_sdk/discord.gd
Loading resource: res://discord_sdk/user.gdns
Loading resource: res://discord_sdk/image_dimensions.gdns
Loading resource: res://discord_sdk/image_handle.gdns
Loading resource: res://discord_sdk/activity_timestamps.gdns
Loading resource: res://discord_sdk/activity_assets.gdns
Loading resource: res://discord_sdk/party_size.gdns
Loading resource: res://discord_sdk/activity_party.gdns
Loading resource: res://discord_sdk/activity_secrets.gdns
Loading resource: res://discord_sdk/activity.gdns
Loading resource: res://discord_sdk/activity_manager.gdns
Loading resource: res://discord_sdk/presence.gdns
Loading resource: res://discord_sdk/relationship.gdns
Loading resource: res://discord_sdk/relationship_manager.gdns
Loading resource: res://discord_sdk/discord.gd
Loading resource: res://discord_sdk/user.gdns
Loading resource: res://discord_sdk/image_dimensions.gdns
Loading resource: res://discord_sdk/image_handle.gdns
Loading resource: res://discord_sdk/activity_timestamps.gdns
Loading resource: res://discord_sdk/activity_assets.gdns
Loading resource: res://discord_sdk/party_size.gdns
Loading resource: res://discord_sdk/activity_party.gdns
Loading resource: res://discord_sdk/activity_secrets.gdns
Loading resource: res://discord_sdk/activity.gdns
Loading resource: res://discord_sdk/presence.gdns
Loading resource: res://discord_sdk/relationship.gdns
Loading resource: res://discord_sdk/relationship_manager.gdns
Loading resource: res://discord_sdk/discord.gd
Loading resource: res://discord_sdk/user.gdns
Loading resource: res://discord_sdk/image_dimensions.gdns
Loading resource: res://discord_sdk/image_handle.gdns
Loading resource: res://discord_sdk/activity_timestamps.gdns
Loading resource: res://discord_sdk/activity_assets.gdns
Loading resource: res://discord_sdk/party_size.gdns
Loading resource: res://discord_sdk/activity_party.gdns
Loading resource: res://discord_sdk/activity_secrets.gdns
Loading resource: res://discord_sdk/activity.gdns
Loading resource: res://discord_sdk/presence.gdns
Loading resource: res://discord_sdk/relationship.gdns
Loaded builtin certs
Loading resource: res://scenes/main.tscn
Loading resource: res://assets/theme.tres
Loading resource: res://assets/fonts/notosans_ui_regular.ttf
Loading resource: res://scripts/main.gd
Loading resource: res://icon.png
Loading resource: res://assets/fonts/notosans_ui_bold.ttf
Loading resource: res://scenes/menus/main.tscn
Loading resource: res://scripts/menus/main.gd
Loading resource: res://scenes/menus/users.tscn
Loading resource: res://scenes/menus/users/get_user.tscn
Loading resource: res://assets/fonts/header.tres
Loading resource: res://scripts/menus/users/get_user.gd
Loading resource: res://scenes/resource_displays/user.tscn
Loading resource: res://scripts/resource_displays/user.gd
Loading resource: res://scenes/menus/users/current_user.tscn
Loading resource: res://scripts/menus/users/current_user.gd
Loading resource: res://scenes/menus/images.tscn
Loading resource: res://scenes/menus/images/fetch.tscn
Loading resource: res://scripts/menus/images/fetch.gd
Loading resource: res://scenes/menus/activities.tscn
Loading resource: res://scenes/menus/activities/register_command.tscn
Loading resource: res://scripts/menus/activities/register_command.gd
Loading resource: res://scenes/menus/activities/register_steam.tscn
Loading resource: res://scripts/menus/activities/register_steam.gd
Loading resource: res://scenes/menus/activities/update_activity.tscn
Loading resource: res://scripts/menus/activities/update_activity.gd
Loading resource: res://scenes/resource_inputs/activity.tscn
Loading resource: res://scenes/resource_inputs/activity_timestamps.tscn
Loading resource: res://scripts/resource_inputs/activity_timestamps.gd
Loading resource: res://scenes/resource_inputs/activity_assets.tscn
Loading resource: res://scripts/resource_inputs/activity_assets.gd
Loading resource: res://scenes/resource_inputs/activity_party.tscn
Loading resource: res://scenes/resource_inputs/party_size.tscn
Loading resource: res://scripts/resource_inputs/party_size.gd
Loading resource: res://scripts/resource_inputs/activity_party.gd
Loading resource: res://scenes/resource_inputs/activity_secrets.tscn
Loading resource: res://scripts/resource_inputs/activity_secrets.gd
Loading resource: res://scripts/resource_inputs/activity.gd
Loading resource: res://scenes/menus/activities/clear_activity.tscn
Loading resource: res://scripts/menus/activities/clear_activity.gd
Loading resource: res://scenes/menus/activities/send_request_reply.tscn
Loading resource: res://scripts/menus/activities/send_request_reply.gd
Loading resource: res://scenes/menus/activities/send_invite.tscn
Loading resource: res://scripts/menus/activities/send_invite.gd
Loading resource: res://scenes/menus/activities/accept_invite.tscn
Loading resource: res://scripts/menus/activities/accept_invite.gd
Loading resource: res://scenes/menus/activities/activity_joined.tscn
Loading resource: res://scripts/menus/activities/activity_joined.gd
Loading resource: res://scenes/menus/activities/activity_spectated.tscn
Loading resource: res://scripts/menus/activities/activity_spectated.gd
Loading resource: res://scenes/menus/activities/activity_join_requested.tscn
Loading resource: res://scripts/menus/activities/activity_join_requested.gd
Loading resource: res://scenes/menus/activities/activity_invite.tscn
Loading resource: res://scripts/menus/activities/activity_invite.gd
Loading resource: res://scenes/resource_displays/activity.tscn
Loading resource: res://scenes/resource_displays/activity_timestamps.tscn
Loading resource: res://scripts/resource_displays/activity_timestamps.gd
Loading resource: res://scenes/resource_displays/activity_secrets.tscn
Loading resource: res://scripts/resource_displays/activity_secrets.gd
Loading resource: res://scenes/resource_displays/activity_party.tscn
Loading resource: res://scenes/resource_displays/party_size.tscn
Loading resource: res://scripts/resource_displays/party_size.gd
Loading resource: res://scripts/resource_displays/activity_party.gd
Loading resource: res://scenes/resource_displays/activity_assets.tscn
Loading resource: res://scripts/resource_displays/activity_assets.gd
Loading resource: res://scripts/resource_displays/activity.gd
Loading resource: res://scenes/menus/relationships.tscn
Loading resource: res://scenes/menus/relationships/filter.tscn
Loading resource: res://scripts/menus/relationships/filter.gd
Loading resource: res://scenes/code_editor.tscn
Loading resource: res://assets/fonts/sourcecodepro_regular.otf
Loading resource: res://scripts/code_editor.gd
Loading resource: res://scenes/menus/relationships/get.tscn
Loading resource: res://scripts/menus/relationships/get.gd
Loading resource: res://scenes/resource_displays/relationship.tscn
Loading resource: res://scripts/resource_displays/relationship.gd
Loading resource: res://scenes/resource_displays/presence.tscn
Loading resource: res://scripts/resource_displays/presence.gd
Loading resource: res://scenes/menus/relationships/get_at.tscn
Loading resource: res://scripts/menus/relationships/get_at.gd
Loading resource: res://scenes/menus/relationships/count.tscn
Loading resource: res://scripts/menus/relationships/count.gd
Loading resource: res://scenes/menus/relationships/relationship_update.tscn
Loading resource: res://scripts/menus/relationships/relationship_update.gd
Socket error: 10054
LennyPhoenix commented 3 years ago

Hey, what OS are you currently using? I was getting an issue like this while testing on Linux.

LennyPhoenix commented 3 years ago

Can you also verify that this issue doesn't occur when you don't call discord.create?

WheatleyHDD commented 3 years ago

I checked on Windows 10. Yes, when commenting on a line with call_deferred("create_core") in file res://scripts/autoload/discord_manager.gd the application starts without problems. image

LennyPhoenix commented 3 years ago

How did you compile the library? Also check a couple things quickly:

WheatleyHDD commented 3 years ago

I downloaded the latest library from the Github Actions page. Discord GameSDK I checked, version 2.5.6

LennyPhoenix commented 3 years ago

Did you download the Debug or Release build?

WheatleyHDD commented 3 years ago

I download release build

LennyPhoenix commented 3 years ago

Ok, ill see if I can replicate the issue and solve it

LennyPhoenix commented 3 years ago

Good news! I identified the issue, looks like I was running core->destroy when I didn't need to: d40f0a8