LennyPhoenix / GodotDiscordSDK

A Discord Game SDK wrapper for Godot, written in C.
MIT License
54 stars 5 forks source link

FEATURE: Add activity manager. #2

Closed LennyPhoenix closed 3 years ago

LennyPhoenix commented 3 years ago

Adds support for the activity manager and all its methods, events and data models.

Progress

JezSonic commented 3 years ago

I have a question. You're doing amazing job, how can I help you? (My and my friend's game is using this pulgin also) I see you have a lot of work to do on this, so i think we can try to help you

LennyPhoenix commented 3 years ago

Hey, as of right now I'm trying to figure out the most efficient method for the nested objects to work (this can be seen in data classes like the ActivityPartyand Activity), I'm yet to write any contributing guidelines, but the next thing I'm going to work on after this PR is the relationships manager, which you could start work on now if you want to. Once I have the nested objects working this PR should be done pretty quickly as there isn't much to add after that, the biggest issue right now is having the right type hints for Resource properties, as errors like this are appearing allot:

image (If you have any ideas for this, please let me know :P)

Here is the project board for things I want to get done for the 1.0 release. I'm probably going to do a pre-release once Activities has been finished.

LennyPhoenix commented 3 years ago

Remember we also have a discussions page for if you want to ask about adding features or making changes :)

JezSonic commented 3 years ago

Ok, i didnt see discussions page, i have forked repo, ill try to implement things i need like register command etc also i can help you with parties if you need more people than one to test it

LennyPhoenix commented 3 years ago

I also need to implement the log hook system at some point, which I can probably get around to later today, as this is something I forgot to do when I first wrote the Core.

LennyPhoenix commented 3 years ago

As for contributing to this: feel free to open a PR targeted to the activities branch 👍

JezSonic commented 3 years ago

Okie :D

LennyPhoenix commented 3 years ago

I also need to implement the log hook system at some point, which I can probably get around to later today, as this is something I forgot to do when I first wrote the Core.

Regarding this, just finished the implementation so it should be on main now.

JezSonic commented 3 years ago

For now I'm trying to implement register_command() function. reguster_steam() will be next

LennyPhoenix commented 3 years ago

I am having some issues with update_activity and clear_activity, so I'm going to do some testing to try and get them to work.