search

LennysLounge / ACC-Race-Control

A live timing app for Assett Corsa Competizione
MIT License
32 stars 5 forks source link

Suggestion : Write Incidents to a Local File. #10

Open mahsoommoosa42 opened 3 years ago

mahsoommoosa42 commented 3 years ago

The Google Sheets solution seems a bit convoluted as obtaining the credentials.json may not be for everyone. Additionally, i can imagine users leaving the json insecure and risking someone obtaining access to their google sheets.

Have you thought of implementing it via a Local File? Perhaps, save it to a Local CSV or XLSX?

mahsoommoosa42 commented 3 years ago

I would gladly be willing to assist to add this feature.

LennysLounge commented 3 years ago

Writing to a local file hasnt really been a priority so far but there is not reason why that couldn't be a feature. I would prefer CSV since thats the easiest but its still human readable.

I have done something similar before with a json file. There i update the file everytime a new incident comes in so there is no need to save the file explicitly. Also removes the possibility of forgetting to save it.

In regards to the credentials.json; i am not a expert on Google API stuff but the credentials should be safe since you still have to log in with yout google account to use it. In a perfect world i would supply the credentials to the user myself but there is a 100 person limit on an unverified application and i have no idea how to get it verified.

Feel free to give it a go, im here for any questions on my weird code.

mahsoommoosa42 commented 3 years ago

Alright. Time to brush up my Java again.

Get Outlook for iOShttps://aka.ms/o0ukef

From: Leonard Schüngel @.> Sent: Thursday, August 12, 2021 5:43:10 PM To: LennysLounge/ACC-Race-Control @.> Cc: mahsoommoosa42 @.>; Author @.> Subject: Re: [LennysLounge/ACC-Race-Control] Suggestion : Write Incidents to a Local File. (#10)

Writing to a local file hasnt really been a priority so far but there is not reason why that couldn't be a feature. I would prefer CSV since thats the easiest but its still human readable.

I have done something similar before with a json file. There i update the file everytime a new incident comes in so there is no need to save the file explicitly. Also removes the possibility of forgetting to save it.

In regards to the credentials.json; i am not a expert on Google API stuff but the credentials should be safe since you still have to log in with yout google account to use it. In a perfect world i would supply the credentials to the user myself but there is a 100 person limit on an unverified application and i have no idea how to get it verified.

Feel free to give it a go, im here for any questions on my weird code.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://apac01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FLennysLounge%2FACC-Race-Control%2Fissues%2F10%23issuecomment-897588338&data=04%7C01%7C%7Cad54fd06a594485d8bd408d95d8a8ddd%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637643672282214362%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=26jzGhPy8zJHyVCQKELZ%2FCvMD%2BO2JyI6WJzy1Q8i%2Fmc%3D&reserved=0, or unsubscribehttps://apac01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAFA4ITPGW57IYB3LEJSDT6DT4O3FNANCNFSM5CA6PW7A&data=04%7C01%7C%7Cad54fd06a594485d8bd408d95d8a8ddd%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637643672282214362%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=uyPjNc%2F7tLzgH8qFn1Tt70FW6L9W7BBz6Emyitj%2BEx4%3D&reserved=0. Triage notifications on the go with GitHub Mobile for iOShttps://apac01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapps.apple.com%2Fapp%2Fapple-store%2Fid1477376905%3Fct%3Dnotification-email%26mt%3D8%26pt%3D524675&data=04%7C01%7C%7Cad54fd06a594485d8bd408d95d8a8ddd%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637643672282224316%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=mED6j0ksH2x%2BnN0BXEduOOQA2ntfOpOpfs0l%2Bb32AoY%3D&reserved=0 or Androidhttps://apac01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dcom.github.android%26utm_campaign%3Dnotification-email&data=04%7C01%7C%7Cad54fd06a594485d8bd408d95d8a8ddd%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637643672282224316%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=cJUVLgvvjWofIB%2Fk7V8QjHuwWuCjSLJCji4ouak%2BMAI%3D&reserved=0.

RualdOrdelman commented 6 months ago

Is there an update for this feature? Our community also wants to try this great tool. However, we need a JSON or CSV export of the incidents instead of the Google Sheet integration.

LennysLounge commented 5 months ago

I dont think this other person ever did anything with it. It shouldnt be to hard to implement this kind of feature.