Build hardware drivers with VNDK enabled

[Quallenauge]

Although it's not clear if the SOC is able to boot into a VNDK in future, but I'd like the idea that we are ready for it, at least for our hw drivers.

[vladimiroltean]

The commit message for wcnss: Build libgnss with the VNDK. is incorrect. You were referring to libwcnss_qmi. It would be nice if you could pick up the additional patches in this pull request: https://github.com/Lenovo-YTX703-Devel/android_device_lenovo_YTX703-common/pull/29 and integrate them into yours when resending, so that we can merge.

[vladimiroltean]

To build a full image with the VNDK enabled, you also need these 2 patchsets:

• https://review.lineageos.org/#/c/LineageOS/android_hardware_qcom_audio/+/220562/
• https://review.lineageos.org/#/c/LineageOS/android_hardware_qcom_media/+/220567/

As discussed, currently the blocker is the hwcomposer HAL, which has non-trivial dependencies on system libraries libskia and libmedia.

[vladimiroltean]

Diff statistics: +43 −19,384 If the code is really unused, why does it cause compilation issues with VNDK enabled?

[Quallenauge]

Camera test application code: Maybe we can let the test code in our repo, but I don't think the modules are needed for a common build. That's why compilation issues (not only VNDK related doesn't appears). When I tried to compile with mm, which compiled all components at the folder, I got some errors, which I was not able to solve (easily). I might be wrong, but it seems that the code wasn't maintained for a long time. So my approach was to remove these components, because they are available also at the CAF upstream code.

Do you think we should let them in as reference implementation which is not used but to complete the camera repo package ? Or I have to remove the code with a separate commit.

Android.bp: That's the next big thing to convert all of the mk files to bp files :) I have to admit, I'm lacking experience at this field... So here I concentrated to the *.mk files.

[Quallenauge]

Would it be better to remove the two commits in question?!

[vladimiroltean]

I would keep the patchset as minimal as possible for VNDK purposes. In this context, maybe a test with mm is irrelevant.

[Quallenauge]

I removed the two commits and re-pushed.