LenweSaralonde / Musician

Add-on for World of Warcraft to perform music in game.
https://musician.lenwe.io
GNU General Public License v3.0
11 stars 4 forks source link

Standard nameplates don't show up even when "Show nameplates when the UI is hidden." is checked #80

Closed LenweSaralonde closed 2 years ago

LenweSaralonde commented 2 years ago

Nameplates are not visible. Sometimes, only the musical note is visible.

EDIT: This bug seems to be caused by Narcissus. When the UI is shown and hidden, a fade animation is played on the nameplates, this - could - be related.

image

LenweSaralonde commented 2 years ago

This issue seems to be caused by Narcissus. It's no longer reproducible when Narcissus is disabled.

LenweSaralonde commented 2 years ago

The root cause is Narcissus sets the UnitNameFriendlyPlayerName CVar to 0 which makes the nameplate name to disappear, but not the whole nameplate.

This is not a problem with Narcissus but with the Musician nameplates module that doesn't handle the UnitNameFriendlyPlayerName CVar properly.

Handling UnitNameEnemyPlayerName would be useful as well for cross-faction.

The solution would be to not display the note icon if UnitNameFriendlyPlayerName / UnitNameEnemyPlayerName is set to 0.