Lua Error for BetterBags when Plugin is enabled

When the plugin gearfirst is enabled, BetterBags throws an error during login or /rl

Message: Interface/AddOns/BetterBags/frames/grid.lua:161: invalid order function for sorting Time: Sat Jul 27 20:23:45 2024 Count: 1 Stack: Interface/AddOns/BetterBags/frames/grid.lua:161: invalid order function for sorting [string "@Interface/AddOns/BetterBags/frames/grid.lua"]:161: in function Sort' [string "@Interface/AddOns/BetterBags/views/gridview.lua"]:247: in functionRender' [string "@Interface/AddOns/BetterBags/frames/bag.lua"]:258: in function Draw' [string "@Interface/AddOns/BetterBags/core/init.lua"]:257: in functioncb' [string "@Interface/AddOns/BetterBags/core/events.lua"]:50: in function <Interface/AddOns/BetterBags/core/events.lua:45>

[string "@Interface/AddOns/ElvUI_Libraries/Core/CallbackHandler-1.0/CallbackHandler-1.0.lua"]:19: in function <...ies/Core/CallbackHandler-1.0/CallbackHandler-1.0.lua:15> [string "@Interface/AddOns/ElvUI_Libraries/Core/CallbackHandler-1.0/CallbackHandler-1.0.lua"]:54: in function `SendMessage' [string "@Interface/AddOns/BetterBags/core/events.lua"]:186: in function <Interface/AddOns/BetterBags/core/events.lua:185>

Locals: self =

{ view =

{ } columns =

{ } sortVertical = true spacing = 4 cells =

{ } maxCellWidth = 2 box = BetterBagsScrollGrid1 { } headers =

{ } cellToColumn =

{ } idToCell =

{ } compactStyle = 0 inner = Frame { } frame = BetterBagsScrollGrid1 { } cellToID =

{ } bar = Frame { } }

ingham-tyler commented 3 months ago

`Date: 2024-08-03 16:55:56 ID: 1 Error occured in: Global Count: 1 Message: Interface/AddOns/BetterBags/frames/grid.lua line 163: invalid order function for sorting Debug:

[string "@Interface/AddOns/BetterBags/frames/grid.lua"]:163: Sort() [string "@Interface/AddOns/BetterBags/views/gridview.lua"]:264: Render() [string "@Interface/AddOns/BetterBags/frames/bag.lua"]:302: Draw() [string "@Interface/AddOns/BetterBags/core/init.lua"]:258: cb()

  Interface/AddOns/BetterBags/core/events.lua:45

  ...ons/libs/CallbackHandler-1.0/CallbackHandler-1.0.lua:15

string "@Interface/AddOns/AdvancedInterfaceOptions/libs/CallbackHandler-1.0/CallbackHandler-1.0.lua":54: SendMessage()

  Interface/AddOns/BetterBags/core/events.lua:185

Locals: (temporary) =

{ 1 =

{ } 2 =

{ } 3 =

{ } 4 =

{ } 5 =

{ } 6 =

{ } 7 =

{ } 8 =

{ } 9 =

{ } 10 =

{ } 11 =

{ } 12 =

{ } 13 =

{ } 14 =

{ } 15 =

{ } 16 =

{ } 17 =

{ } 18 =

{ } 19 =

{ } 20 =

{ } 21 =

{ } 22 =

{ } 23 =

{ } 24 =

{ } 25 =

{ } 26 =

{ } 27 =

{ } 28 =

{ } } (temporary) =

{ view = 2 headerDisabled = false title = Button { } fillWidth = false maxItemsPerRow = 7 content =

{ } frame = Frame { } } (temporary) =

{ view = 2 headerDisabled = false title = Button { } fillWidth = false maxItemsPerRow = 7 content =

{ } frame = Frame { } } (temporary) =

{ view = 2 headerDisabled = false title = Button { } fillWidth = false maxItemsPerRow = 7 content =

{ } frame = Frame { } }

AddOns: Swatter, v<%version%> (<%codename%>) AddonFactory, v11.0.001 AdvancedInterfaceOptions, v2.0.0 AllTheThings, vTWW-4.0.2 Altoholic, v11.0.001 Auctionator, v11.0.0 Auctioneer, v9.1.BETA.5.17 (OneMawTime) AuctioneerStatsOverTime, v9.1.BETA.5.17 (OneMawTime) AuctioneerUtilDealFinder, v9.1.BETA.5.17 (OneMawTime) AuctioneerUtilValuer, v9.1.BETA.5.17 (OneMawTime) BattleGroundEnemies, v11.0.0.0 BetterBags, vv0.1.89 BetterBagsBound, vv1.2.0 BetterBagsDragonflightReputationInsignia, vv1.2.0 BetterBagsGearFirst, vv1.0.8 BetterBagsHearthstones, v1.18 BetterBagsWorldEvents, v1.3.3 BetterFishing, v1.1.24 BigDebuffs, vv29 Capping, vv10.2.12 DataStore, v2024.07.28 DataStoreAchievements, v2024.07.28 DataStoreAgenda, v2024.07.28 DataStoreAuctions, v2024.07.28 DataStoreCharacters, v2024.07.28 DataStoreContainers, v2024.07.28 DataStoreCrafts, v2024.07.28 DataStoreCurrencies, v2024.07.28 DataStoreGarrisons, v2024.07.28 DataStoreInventory, v2024.07.28 DataStoreMails, v2024.07.28 DataStorePets, v2024.07.28 DataStoreQuests, v2024.07.28 DataStoreReputations, v2024.07.28 DataStoreSpells, v2024.07.28 DataStoreStats, v2024.07.28 DataStoreTalents, v2024.07.28 DejaCharacterStats, vR110000r1 Details, v#Details.12827.159 DetailsCompare2, v DetailsEncounterDetails, v DialogueUI, v0.3.6 HandyNotes, vv1.6.20.3 HandyNotesBattleForAzerothTreasures, vv32 HandyNotesBurningCrusade, vv6 HandyNotesDragonflightTreasures, vv60 HandyNotesDragonGlyphs, v0.1.5 HandyNotesHigherDimensionalLearning, vv6 HandyNotesKosumoth, vv9 HandyNotesLegionTreasures, vv35.1 HandyNotesLongForgottenHippogryph, vv12 HandyNotesMistsOfPandariaTreasures, vv33 HandyNotesSecretFish, vv6 HandyNotesShadowlandsTreasures, vv78 HandyNotesStygia, vv110000.0 HandyNotesSuramarLeylines, vv8 HandyNotesSuramarTelemancy, vv13 HandyNotesTreasureHunter, vv35 HandyNotesWitheredArmyTraining, v1 HandyNotesWrathOfTheLichKing, vv14 Informant, v9.1.BETA.5.17 (OneMawTime) KrowiAchievementFilter, v75.2 LeatrixMaps, v11.0.02 LeatrixPlus, v11.0.02 MasterPlanA, vA MinimalArchaeology, v11.0.0 Narcissus, v1.6.7 OmniCC, v11.0.0 OPie, vZeta 8a Plumber, v1.3.3 Postal, vv4.1.8 PremadeGroupsFilter, v5.8.2 RareScanner, v11.0.0.1 Rarity, v1.0 (r733-release) RarityOptions, v SavedInstances, v11.0.2 SpeedyAutoLoot, v2.2.21 Stubby, v9.1.BETA.5.17 (OneMawTime) TomTom, vv4.0.1-release VenturePlan, v4.42 WarPlan, v3.26 WeakAuras, v5.15.4 WeakAurasArchive, v5.15.4 ZerethMortisPuzzleHelper, v1.6.13 BlizRuntimeLib v11.0.0.55939(US) (ck=a4f) `

Getting similar issue. While Gear First addon is enabled transitioning zones, reloading UI, and relogging will throw this error. I did not get this error on first login though. Only after going from Dalaran to Searing Gorge via the in game portal for the Radiant Echoes event, then returning to Dalaran did the error first appear.

YellowPlus commented 3 months ago

I got the similar error when I have multiple gear set categories in my bag

I guess there are some wrongs in the sorting method so I simply add a if statement to the original codes in the main.lua file to fix the problem temporally

if (not(string.find(a.title:GetText(), L:G("Gear") .. ":") and string.find(b.title:GetText(), L:G("Gear") .. ":"))) then
    if string.find(a.title:GetText(), L:G("Gear") .. ":") then return true end
    if string.find(b.title:GetText(), L:G("Gear") .. ":") then return false end
end

not sure if there are other situations that also cause this error

Leo450 commented 2 months ago

Hi mates. I was sadly not able to reproduce. I added a fallback in the sort getter function to Alphabetical sort. Do you still have the lua error ? Is it falling back to alpha sort or does the latest BetterBags updates have fixed the issue completely ?

If you still have it, could you help me investigate by trying to find the use case in which you have the error ?

Maybe a screenshot of your bag items when it's not blank so i can see all the section (item categories) you have to display.
Trying to find the exact setting that making the error show up

Leo450 / betterbags-gearfirst

Lua Error for BetterBags when Plugin is enabled #3