LeoBeliik / ExtremeSoundMuffler

Muffle those nasty sounds - Client side sound Muffler
GNU Lesser General Public License v3.0
20 stars 10 forks source link

Menu doesn't match sounds from other mods correctly 🐞 #47

Closed Sonicwave closed 1 year ago

Sonicwave commented 1 year ago

Extreme sound muffler version

3.31

Forge / Fabric version

42.0.1

Additional mod(s) version (If bug is due incompatibility)

AoA3-1.19.1-3.6.11

Describe the bug

The sound muffling menu doesn't seem to be matching sounds from other mods (at least Advent of Ascension) correctly. Instead of matching "entity.charger.hurt" which is the event name in sounds.json, it shows "charger_hurt", and clicking on the play button doesn't play anything nor is the sound muffled. Manually entering the correct sound key into .minecraft/ESM/soundsMuffled.dat appears to work for both cases.

Based on https://github.com/Tslat/Advent-Of-Ascension/blob/2c802bf74204271dd46499f1c5fe8a55fb9e0d24/source/common/registration/AoASounds.java, it appears the menu is displaying the registry name (matching the behavior above) but the sound event key is expected for the sound to be correctly affected.

Steps to reproduce

No response

Crashlog

No response

Additional context

https://www.curseforge.com/minecraft/mc-mods/advent-of-ascension-nevermine/files/3906971 is the mod being tested against.