LeoBeliik / ExtremeSoundMuffler

Muffle those nasty sounds - Client side sound Muffler
GNU Lesser General Public License v3.0
20 stars 9 forks source link

Invalid icon for Fabric Mod Menu #59

Closed Giacomino99 closed 1 year ago

Giacomino99 commented 1 year ago

Extreme sound muffler version

3.38

Forge / Fabric version

Fabric 0.14.21 (Minecraft 1.20)

Additional mod(s) version (If bug is due incompatibility)

Mod Menu 7.0.1

Describe the bug

When opening the Mods menu in game, an error is thrown relating to the ESM's icon and the icon is not displayed. All icons in the menu must be square and ESM's logo is not.

Steps to reproduce

  1. Go click on "Mods" button on Minecraft main menu.
  2. Scroll down to the listing for "Extreme Sound Muffler."
  3. There should be a default question mark icon displayed instead of the mod's actual icon.
  4. View Minecraft logs to see that the error is caused by the icon not being square.

Crashlog

https://imgur.com/cy1A7Ds

Additional context

Changing the icon (esm_logo.png) to a square version no longer causes an error and displays correctly in game.. I have attached the file that I used to test the fix for the issue. esm_logo

LeoBeliik commented 1 year ago

Does the game crash or just outputs an error?

Giacomino99 commented 1 year ago

It outputs an error and fails to display an icon. It does not crash the game.