LeoColomb / pomo

Gettext library to translate with I18n
GNU General Public License v2.0
9 stars 1 forks source link

Update library #6

Closed ozh closed 7 years ago

ozh commented 7 years ago

Merge & tag 1.4 ? :)

LeoColomb commented 7 years ago

Wow, cool, thanks! 👍

Just wondering how do you manage to pull original changes from WordPress? (in fact I see some updates not reflected here, eg: wp-includes/pomo/mo.php#L18-L32...)

ozh commented 7 years ago

Actually I didn't completely reviewed all the changes on the WP lib, I just updated the most needed parts (ie tests failing or code deprecated in 7.2) Also it seems this function get_filename() you link isn't even used somewhere else...

As of now code coverage is around 80% for the whole lib and all tests in the lib + YOURLS pass, so I guess that's good enough :P

ozh commented 7 years ago

(Regarding PHP 7.2, there's still one create_function() left, it'll be a bit trickier to circumvent, I'll get to this later)

LeoColomb commented 7 years ago

Right, thanks! 😃