LeoIannacone / npm2deb

tool to help debianize Node.js modules
GNU General Public License v3.0
46 stars 34 forks source link

Fix BSD case #138

Closed guimard closed 5 years ago

guimard commented 5 years ago

When upstream uses 'BSD-2-Clause', debian/copyright is wrong:

Files: *
Copyright: 2019, ...
License: BSD-2-Clause

License: BSD-2-clause

This fix uses the same license as given by upstream. Another way could be to just fix license name in templates.py

shanavas786 commented 5 years ago

I am not sure about the requirement here. debian packaging manual uses BSD-2-clause with lowercase clause.

It seems changing names in template.py will make it compliant with manual.

guimard commented 5 years ago

@shanavas786: yes but today, npm2deb provides a bad debian/changelog since many npm modules uses "BSD-3-Clause" and not "BSD-3-clause". cme check dpkg-copyright reports this issue.

guimard commented 5 years ago

Another way is to fix "License:" field. In this MR, I just copy the same name to be sure to have a good license ref.