search

LeoIannacone / npm2deb

tool to help debianize Node.js modules
GNU General Public License v3.0
46 stars 34 forks source link

send itp mail via npm2deb #148

Open nileshpatra opened 4 years ago

nileshpatra commented 4 years ago

Solves #45

nileshpatra commented 4 years ago

@guimard , did the changes as desired, using mail + editor.(seems to work on my machine) Could you please review?

guimard commented 4 years ago

@guimard , did the changes as desired, using mail + editor.(seems to work on my machine) Could you please review?

Seems good for me. However, I've no talents in Python. I let review for someone else

nileshpatra commented 4 years ago

@guimard , did the changes as desired, using mail + editor.(seems to work on my machine) Could you please review?

Seems good for me. However, I've no talents in Python. I let review for someone else

Noted, Thanks a lot for guiding me, :)

@shanavas786 @LeoIannacone could you please review the PR?

shanavas786 commented 4 years ago

@nileshpatra Thanks for your contribution

did the changes as desired, using mail + editor.(seems to work on my machine)

Does it invoke editor in your system ?

nileshpatra commented 4 years ago

@nileshpatra Thanks for your contribution

did the changes as desired, using mail + editor.(seems to work on my machine)

Does it invoke editor in your system ?

No, you would need to modify the template (_itp.mail) on doing npm2deb senditpmail package-name_itp.mail, it should send the mail.

shanavas786 commented 4 years ago

well, then the subject should not contain 'FIX_ME', would be better to capture it from user. You may also warn/abort if the ITP file contains any 'FIX_ME' s