Open nileshpatra opened 4 years ago
@guimard , did the changes as desired, using mail + editor.(seems to work on my machine) Could you please review?
@guimard , did the changes as desired, using mail + editor.(seems to work on my machine) Could you please review?
Seems good for me. However, I've no talents in Python. I let review for someone else
@guimard , did the changes as desired, using mail + editor.(seems to work on my machine) Could you please review?
Seems good for me. However, I've no talents in Python. I let review for someone else
Noted, Thanks a lot for guiding me, :)
@shanavas786 @LeoIannacone could you please review the PR?
@nileshpatra Thanks for your contribution
did the changes as desired, using mail + editor.(seems to work on my machine)
Does it invoke editor in your system ?
@nileshpatra Thanks for your contribution
did the changes as desired, using mail + editor.(seems to work on my machine)
Does it invoke editor in your system ?
No, you would need to modify the template (_itp.mail) on doing npm2deb senditpmail package-name_itp.mail, it should send the mail.
well, then the subject should not contain 'FIX_ME', would be better to capture it from user. You may also warn/abort if the ITP file contains any 'FIX_ME' s
Solves #45