search

LeoKlaus / plappa

An Audiobook client for Jellyfin and AudioBookShelf, written in Swift/SwiftUI.
https://plappa.me
160 stars 0 forks source link

[BUG] Tapping a Book won't start Playback #31

Closed mutschler closed 2 months ago

mutschler commented 2 months ago

Describe the bug Single tapping a book will not start Playback you have to long tap it to bring up the menu and select listen.

Expected behavior I'd expect on single tapping the book to play it

Environment(please complete the following information):

LeoKlaus commented 2 months ago

I assume you're talking about any of the lists of books? I felt like that might be a bit unintuitive, but I don't see why I shouldn't just give you an option to select the preferred behavior.

mutschler commented 2 months ago

Yes i was Talking Abluft any of the list views.

I just checked a few other apps and how those handle tapping on media items and while i can understand your concern about it being unintuitive to start playaback by tapping it I do think tapping should do at least anything. Currently it just does nothing which feels kinda weird tbh.

Here are some ideas what could happen when tapping the entry:

Depending on which App you'll look at most of them implement one of that functions on click and have more options behind a sheet coming up when long-pressing or hitting the "more" icon.

BTW: is there currently a way to get details of an entry? Like description, series etc? If not I'd love to have that option as well!

mutschler commented 2 months ago

Holy... that's some weird behaviour... i found out what confused me! Just found out that there is already a implementation on single tap... just not consistent everywhere!

I'd like to change my report:

Please make it so tapping the Element from enywhere opens the Detail page. Currently that only works in the special occasion:

  1. Go to Home View
  2. Click any of the Headlines ("where you...", "recentyl added" etc)
  3. Click a book and see detail view

Now try this:

  1. Go to Home View or Books
  2. Click Book
  3. Nothing happens

so where it works as i would expect it to:

where it doesn't:

Maybe the video makes it more clear: https://github.com/LeoKlaus/plappa/assets/18465333/57794bbf-651a-4a44-ac58-e984bcb86840

LeoKlaus commented 2 months ago

I'm slowly getting the impression that there's something very weird going on in your case, this is how interaction with the list of books should work:

https://github.com/LeoKlaus/plappa/assets/66492595/a7237875-c6bc-43b3-a74d-d3913eab6fc5

If it doesn't work that way on your device, that's a bug and very much not how plappa is intended to work :D

LeoKlaus commented 2 months ago

Okay, I see we found the issue!

That's curious. As you can see in the video I posted, the books in the list are indeed tappable and do exactly what you want them to. I wonder if iOS 16 is to blame for this. You're the only person that has reported this so far...

LeoKlaus commented 2 months ago

I'll have to set up a simulator with iOS 16 to verify this, I'll let you know once I know more!

LeoKlaus commented 2 months ago

This was indeed related to iOS 16. I've fixed this with update 1.1.1 which should release in the coming days.

mutschler commented 2 months ago

Awesome. I'll check and report back :)

LeoKlaus commented 2 months ago

Awesome. I'll check and report back :)

Great! Keep in mind that the update is not live yet, I'll let you know once it is.

LeoKlaus commented 2 months ago

1.1.1 is now live on the AppStore! You might have to check manually for the update as it's just been released.

mutschler commented 2 months ago

Seem's to work now :)