LeoKlaus / plappa

An Audiobook client for Jellyfin and AudioBookShelf, written in Swift/SwiftUI.
https://plappa.me
159 stars 0 forks source link

[BUG] Finished book is not marked as finished in ABS #92

Closed mrburns-42 closed 1 month ago

mrburns-42 commented 1 month ago

Describe the bug If I listen to a book to the end in Plappa, it is marked as finished in Plappa, but not in ABS.

To Reproduce Steps to reproduce the behavior:

  1. Listen to an audiobook to the end in Plappa
  2. Go to the ABS app
  3. Search the audiobook
  4. The audiobook is finished, but not marked as finished

Expected behavior If an audio book has been finished in Plappa, this should also be marked as finished in ABS.

Environment(please complete the following information):

Additional context Marking a book as finished has several advantages:

  1. the book is listed in ABS among the finished audiobooks and can be filtered accordingly.
  2. the book is listed in ABS under Listen again.
  3. if the book is part of a series, the next volume will be displayed under Continue series.
mrburns-42 commented 1 month ago

The problem does not always seem to occur. I have just finished an audiobook which was correctly marked as finished. This was not the case with the previous three.

mrburns-42 commented 1 month ago

Sorry for the many entries, there's an update: I just checked ABS again and the book was no longer marked as finished. The progress was back to 0 percent. In the meantime, I deleted the local copy of the book in Plappa and started another book ... nothing more.

wfrank21 commented 1 month ago

Having the same issue here. Jellyfin and ABS. No playback time is recorded in the statistics of ABS as well.

mrburns-42 commented 1 month ago

@wfrank21 Then at least I'm not alone with the problem. The fact that the listening time does not appear in the ABS statistics must be due to the fact that the ABS listening sessions #15 have not yet been implemented.

LeoKlaus commented 1 month ago

Thank you both for reporting this!

I believe I have identified the issue and implemented a fix, it is available in TestFlight now (1.1.5 build 10).

mrburns-42 commented 1 month ago

@LeoKlaus I will test it and will give you a feedback.

wfrank21 commented 1 month ago

@LeoKlaus How long until this will be available on TestFlight? I only see 1.1.5 (8)

LeoKlaus commented 1 month ago

@LeoKlaus How long until this will be available on TestFlight? I only see 1.1.5 (8)

I've only released it to a group you're not part of, my bad. Should be available to you now.

wfrank21 commented 1 month ago

Thanks! For me the bug is resolved, Episodes are marked as read in ABS

mrburns-42 commented 1 month ago

I have also tested it, it works now. Many thanks for your efforts.

LeoKlaus commented 1 month ago

Great, I'll close this, then!