search

LeoMelnyk / BGHistorian

WoW classic addon for battlegrounds history and statistics
GNU Affero General Public License v3.0
0 stars 1 forks source link

Horde vs. Horde BG's record losses for the other faction. #4

Closed KevinTyrrell closed 2 years ago

KevinTyrrell commented 2 years ago

Blizzard is extremely dumb and forgot to update their API upon introducing Horde vs. Horde battlegrounds in WoW Classic TBC.

There's an edge case where if you are disguised as alliance/horde, a victory or loss will be recorded as the opposite on BGHistorian. For example if you are a Horde player, disguised as alliance in a battlground, and lose the battleground, it will appear as a win on BGHistorian (because technically a horde team won). The API function GetBattlefieldWinner does not specify if the BG is a same-faction battleground. Therefore the only way to circumvent this is to check for the disguise buff upon the battleground ending.

This bug taints the data recorded by BGHistorian thus making the addon completely useless.

KevinTyrrell commented 2 years ago

Fix live as of a420c3cf4f53ebaef7cb689a7470c0f4a43b3c76

Thank you @LeoMelnyk

Closed.