search

LeoMinecraftModding / eternal-starlight

A minecraft mod that adds the magical and mysterious starlight dimension.
MIT License
25 stars 5 forks source link

Overworld structures in Eternal Dimension (Neoforge 1.21.1) #24

Closed ElTryken closed 2 weeks ago

ElTryken commented 3 weeks ago

Hello, I just installed the mod to explore and it's great. Unfortunately I found that overworld structures are generated in this dimension (Iron's Spells 'n Spellbooks, Dungeons Arise for example) so I wanted to inform you. Greetings

image

image

YocyCraft commented 2 weeks ago

Maybe it's caused by data-driven structure generation.

For example, in file data/irons_spellbooks/tags/worldgen/biome/has_structure/evoker_fort:

{
  "replace": false,
  "_comment": " This biome tag can specify the biome directly. Or specify another biome tag by starting with # ",
  "values": [
    "#minecraft:is_hill",
    "#minecraft:is_forest",
    "#c:is_desert",
    "#c:is_plains",
    "minecraft:windswept_savanna",
    "minecraft:savanna",
    "minecraft:savanna_plateau"
  ]
}

To solve this issue on eternal starlight side, we need to remove all #c:is_{some_type} tags for eternal starlight biomes. However these tags are not only used for determining structure generation, but also for some other game mechanics.

uhloin commented 2 weeks ago

See also: https://github.com/iron431/irons-spells-n-spellbooks/issues/654

LeoLezury commented 2 weeks ago

Will fix soon, I'll just delete those c tags