search

LeoNatan / LNPopupController

A framework for presenting view controllers as popups of other view controllers, much like the Apple Music and Podcasts apps.
MIT License
3.04k stars 340 forks source link

Investigate iOS 11 beta issues #162

Closed LeoNatan closed 7 years ago

LeoNatan commented 7 years ago

Currently, there are several issues with iOS 11 beta that need investigation.

ridersofrohan commented 7 years ago

This is the error when I try to present the popup controller in iOS 11, just to help you try and isolate some of the bugs.

2017-06-20 20:54:30.778237-0700 we.fm[312:10349] Assertion failure in -[UIVisualEffectView _addSubview:positioned:relativeTo:], /BuildRoot/Library/Caches/com.apple.xbs/Sources/UIKit/UIKit-3678.13/UIVisualEffectView.m:1364 2017-06-20 20:54:30.780881-0700 we.fm[312:10349] Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: '<UIView: 0x153d155e0; frame = (0 0; 0 0); layer = <CALayer: 0x1c0821360>> has been added as a subview to <UIVisualEffectView: 0x153dae190; frame = (0 0; 0 0); autoresize = W+H; userInteractionEnabled = NO; layer = <CALayer: 0x1c0231f80>>. Do not add subviews directly to the visual effect view itself, instead add them to the -contentView.'

LeoNatan commented 7 years ago

Yes, I am familiar with this issue. I insert subviews directly to the visual effects view, rather than into its content view.

MosheBerman commented 7 years ago

Can you list some of the issues here, so that we know what's being worked on? (To avoid duplicate issues, as above.)

LeoNatan commented 7 years ago

On the short run:

On the long run, I want to take a look at the new margin systems in iOS 11. Could help me reduce the internal need to swizzle so much. Maybe I can finally implement all the functionality with public APIs.

LeoNatan commented 7 years ago

Fixed all known issues. Investigation of new features will come as a new issue later.