search

LeoNatan / LNPopupController

A framework for presenting view controllers as popups of other view controllers, much like the Apple Music and Podcasts apps.
MIT License
3.04k stars 340 forks source link

iPhone X support #201

Closed artem-shmatkov closed 6 years ago

artem-shmatkov commented 6 years ago

Hi LeoNatan! Sorry to bother you and thank you for the library! It's not an actual issue but a question. How can I achieve a result then popup bar on an iPhone X isn't cutted by safeAreaInsets but going down to the bottom of the screen? Here is an example of current situation and desired result (photoshopped for illustration): current desired Now I'm using full custom popup controller. Is this possible?

LeoNatan commented 6 years ago

Hello,

It is not currently possible to extend the popup bar itself.

You can achieve this by adding a bottom view to your presenting controller. If you set that view to be a UIVisualEffectView with the blur type if the popup bar, you will have the effect you are looking for.

I intend to add this functionality at some point, but haven’t figured yet how to offer a generic API for this. It will also require somewhat of a refactor to achieve.

yarodevuci commented 5 years ago

@LeoNatan bottom view to main VC?

yarodevuci commented 5 years ago

@zakhej did u figure it out?

LeoNatan commented 5 years ago

Add a UIVisualEffectView and set it as the bottom docking view using the bottomDockingViewForPopupBar property.