search

LeoNatan / LNPopupController

A framework for presenting view controllers as popups of other view controllers, much like the Apple Music and Podcasts apps.
MIT License
3.04k stars 342 forks source link

Xcode 12 compile broken #462

Closed LeoNatan closed 3 years ago

LeoNatan commented 3 years ago

Did you try? I have some errors at compile time in each (# or @)available(iOS 15.0, *) check.

Originally posted by @iDevelopper in https://github.com/LeoNatan/LNPopupController/issues/456#issuecomment-870338080

LeoNatan commented 3 years ago

Fixed in 2.11.1 @iDevelopper

iDevelopper commented 3 years ago

Yes, thanks.

However I don't understand #if IPHONE_OS_VERSION_MAX_ALLOWED> IPHONE_14_5, as there is already a version of iOS 14.6 and there will be a 14.7. Is this an Apple inconsistency? __IPHONE_14_6 not defined in AvailabilyVersions.h. And also there is no Simulator for version 14.6.

LeoNatan commented 3 years ago

That’s the SDK version. There is no public 14.6 or 14.7 SDK.

iDevelopper commented 3 years ago

So we must consider that there will be no bug when we test an application that works on iOS 14.5 on iOS 14.6 or 14.7?

LeoNatan commented 3 years ago

I am sorry, I don't understand what you are saying. Xcode 12.x only comes with SDK Version 14.5, so the logic says "if SDK version is above 14.5, compile this". I don't think there will be a later 14.x SDK, so this logic will be fine. Once Xcode 13 has been out for a while, I will require Xcode 13 for the framework and remove these lines.

iDevelopper commented 3 years ago

I don't think you should remove these lines as some users will continue to build with Xcode 12 for a while. Why not :

if __IPHONE_OS_VERSION_MAX_ALLOWED>= 150000

?

LeoNatan commented 3 years ago

That can also be used. Want to create a quick PR with that line? 🙏

LeoNatan commented 3 years ago

I'll do it now.