LeoNatan / LNPopupController

A framework for presenting view controllers as popups of other view controllers, much like the Apple Music and Podcasts apps.
MIT License
3.04k stars 342 forks source link

Example App Crashes on launch #540

Closed gtokman closed 1 year ago

gtokman commented 1 year ago

Description

I downloaded the project and ran the example on simulator and a crash occurred on launch in viewDidLoad.

Screenshot

CleanShot 2023-08-30 at 12 21 16@2x
LeoNatan commented 1 year ago

Hello, someone else reported this, but I couldn’t reproduce. @iDevelopper What OS/hardware?

Thanks!

gtokman commented 1 year ago

I can run the non pop target fine, but the pop up window example crashes every time. I saw you noted a few things about iOS 17 vs 16. But I don't have the new Xcode installed yet to try it.

Xcode 14.3.1 M1 - Ventura 13.5.1

LeoNatan commented 1 year ago

Thanks, I’ll look again.

iDevelopper commented 1 year ago

I can run the non pop target fine also, but the up & down buttons do nothing.

iDevelopper commented 1 year ago

Device iPhone 14 Pro, iOS 17.0 & Simulator, Xcode version 15.0 beta 8 (15A5229m), Mac Ventura 13.4.1 (c).

LeoNatan commented 1 year ago

I see obj is nil for some reason. For me, it doesn't reproduce ever. I will add a check to make sure this crashing flow doesn't happen.

LeoNatan commented 1 year ago

So apparently, iPhone 13 mini, iPhone 14 Pro and iPhone 14 Pro Max behave differently internally. 🤦‍♂️

I think I have fixed this in the latest release. Please test and let me know @gtokman @iDevelopper @jiangdi0924

jiangdi0924 commented 1 year ago

So apparently, iPhone 13 mini, iPhone 14 Pro and iPhone 14 Pro Max behave differently internally. 🤦‍♂️

I think I have fixed this in the latest release. Please test and let me know @gtokman @iDevelopper @jiangdi0924

@LeoNatan i hava test in real device iPhone 14 iOS 17 beta, works fine and is very smooth!!! 🙂

LeoNatan commented 1 year ago

Great, thank you for confirming. Will close the issue for now; let me know if there are more issues.

iDevelopper commented 1 year ago

Hello @LeoNatan,

Tested in real device iPhone 14 Pro iOS 17 beta, works fine!

iDevelopper commented 1 year ago

There is a bug when (TabBarController + Navigation Controller) when push next with hidesBottomBarWhenPushed = true. If we cancel the back animation (swipe) and come back again, the background view disappears.

LeoNatan commented 1 year ago

Hi @iDevelopper Could you please record a video of the problem and upload it? Thanks

iDevelopper commented 1 year ago

Yes,

https://github.com/LeoNatan/LNPopupController/assets/1782450/badc285d-eee9-492d-a51b-16e348857edf

LeoNatan commented 1 year ago

Thanks!

LeoNatan commented 1 year ago

@iDevelopper I found the issue and will fix it in the next release. Thanks for reporting!