LeoNatan / LNPopupController

A framework for presenting view controllers as popups of other view controllers, much like the Apple Music and Podcasts apps.
MIT License
3.04k stars 342 forks source link

Style question #541

Closed rastaman111 closed 1 year ago

rastaman111 commented 1 year ago

Hello I want to change barStyle in real time from prominent to floating, and from floating to prominent

But I faced such problem

Еhat when I return from floating to prominent, the background of the bar does not return to the default state

Attached screenshots, pay attention to 1 and 3

Снимок экрана 2023-09-06 в 10 08 37 Снимок экрана 2023-09-06 в 10 08 52 Снимок экрана 2023-09-06 в 10 09 05
LeoNatan commented 1 year ago

Hello,

This should work as expected. Have you changed the standard appearance by any chance? Perhaps you can post a small sample project, reproducing the issue.

Thanks

rastaman111 commented 1 year ago

The first screen is me showing the Bar, on the second screen I change the style

Снимок экрана 2023-09-06 в 19 04 49 Снимок экрана 2023-09-06 в 19 04 59
LeoNatan commented 1 year ago

Hmm, maybe it’s getting confused with the toolbar style. Could you please create a small project recreating the issue? I am on vacation and will look at it once I’m home. Thanks

rastaman111 commented 1 year ago

yes, okay, one of these days I'll throw off the demo

rastaman111 commented 1 year ago

I also noticed that the floating style does not accept appearance

LeoNatan commented 1 year ago

It does. It just has its own settings for the floating background.

LeoNatan commented 1 year ago

https://github.com/LeoNatan/LNPopupController/blob/43e71be8e7b802f7d1d0bc9a8cc62f036cd7c8d7/LNPopupController/LNPopupController/LNPopupBarAppearance.h#L71

rastaman111 commented 1 year ago

Attached a test project, it repeats the bug TestLNPopup.zip

LeoNatan commented 1 year ago

Fixed in 2.15.6

Please try and let me know.

rastaman111 commented 1 year ago

Hi, I checked the new version, everything works for a long time, super👍🏼