search

LeoNatan / LNPopupUI

A SwiftUI library for presenting views as popups, much like the Apple Music and Podcasts apps.
MIT License
320 stars 29 forks source link

Gesture Conflict #25

Closed jiangdi0924 closed 1 year ago

jiangdi0924 commented 1 year ago

Describe the Bug When using other components (compactslider, https://github.com/buh/CompactSlider) with multiple gesture effects within popupContent, I've noticed conflicts between the events of LNPopupUI and those of the other components. While using .popupInteractionStyle(.none) can resolve the issue, it disables the ability to close the view by dragging. I'm quite puzzled. Do you have any valuable suggestions? Thank you very much for your time.

To Reproduce Steps to reproduce the behavior: I have submitted a case swiftUI repo that you can run if you have time. This repo can reproduce my problem. 👉 https://github.com/jiangdi0924/LNPopupUIGestureConflic

Expected Behavior resolve gesture conflict

Screenshots none

Additional Context none

LeoNatan commented 1 year ago

Please update LNPopupController to 2.15.3 and try in your app. It seems to be much better now in a simple view with CompactSlider, but it should be tested in a more complex app.

LeoNatan commented 1 year ago

So it works well now?

jiangdi0924 commented 1 year ago

So it works well now?

Yeah, it worked perfectly