LeoNatan / LNPopupUI

A SwiftUI library for presenting views as popups, much like the Apple Music and Podcasts apps.
MIT License
320 stars 29 forks source link

Adding title / subtitle to the popup. #4

Closed iTollMouS closed 3 years ago

iTollMouS commented 3 years ago

I am trying to add title and subtitle but it doesn't work .


   .popup(isBarPresented: $isBarPresented, isPopupOpen: $isPopupOpen) {

        }

        .popupImage(Image(systemName: "person"))
        .popupTitle("1356")
        .popupCloseButtonStyle(.chevron)
        .popupInteractionStyle(.drag)
LeoNatan commented 3 years ago

The image and title should be added inside the content view. So, for example, if you have a music app, and the popup presents a music player, the title—the song name—should be set as a title of the popup in the player view.

LeoNatan commented 3 years ago

You can check out the example app in this repo.

iTollMouS commented 3 years ago

“ The image and title should be added inside the content view “ I think that is the answer that I wasn’t seeing it + big thanks for the response

Thank you.

On Nov 19, 2020, at 11:35 AM, Leo Natan notifications@github.com wrote:



The image and title should be added inside the content view. So, for example, if you have a music app, and the popup presents a music player, the title—the song name—should be set as a title of the popup in the player view.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/LeoNatan/LNPopupUI/issues/4#issuecomment-730216094, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AHXPK5KZOBPUGITOKGKBAQTSQTKFNANCNFSM4T3AJ5YA.

LeoNatan commented 3 years ago

Please let me know how it goes. Thanks

iTollMouS commented 3 years ago

For sure

Thank you.

On Nov 19, 2020, at 11:43 AM, Leo Natan notifications@github.com wrote:



Please let me know how it goes. Thanks

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/LeoNatan/LNPopupUI/issues/4#issuecomment-730220210, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AHXPK5J2JCK4EDN76MFLW23SQTLELANCNFSM4T3AJ5YA.

iTollMouS commented 3 years ago

I tried , but the items arent showing up . [cid:83120660-ce2f-4dff-b61d-de3de2deb438]


From: Leo Natan notifications@github.com Sent: Thursday, November 19, 2020 3:43 AM To: LeoNatan/LNPopupUI LNPopupUI@noreply.github.com Cc: iTollMouS tariq.almazyad@hotmail.com; Author author@noreply.github.com Subject: Re: [LeoNatan/LNPopupUI] Adding title / subtitle to the popup. (#4)

Please let me know how it goes. Thanks

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/LeoNatan/LNPopupUI/issues/4#issuecomment-730220210, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AHXPK5J2JCK4EDN76MFLW23SQTLELANCNFSM4T3AJ5YA.

iTollMouS commented 3 years ago

Here is my simple attempt . https://github.com/iTollMouS/WakaTime-Tracker/blob/main/WakaTime%20Tracker/ContentView.swift

i am not sure how to make it happend


From: Leo Natan notifications@github.com Sent: Thursday, November 19, 2020 3:43 AM To: LeoNatan/LNPopupUI LNPopupUI@noreply.github.com Cc: iTollMouS tariq.almazyad@hotmail.com; Author author@noreply.github.com Subject: Re: [LeoNatan/LNPopupUI] Adding title / subtitle to the popup. (#4)

Please let me know how it goes. Thanks

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/LeoNatan/LNPopupUI/issues/4#issuecomment-730220210, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AHXPK5J2JCK4EDN76MFLW23SQTLELANCNFSM4T3AJ5YA.

LeoNatan commented 3 years ago

Did you look at the demo project?

iTollMouS commented 3 years ago

I did , and I even copied the same exact structural code as TabView {

} .present the pop up .popuptitle( text text ) pupupsubtitle ( text )

And it doesn’t show .

Thank you.

On Nov 19, 2020, at 5:25 PM, Leo Natan notifications@github.com wrote:



Did you look at the demo project?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/LeoNatan/LNPopupUI/issues/4#issuecomment-730409739, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AHXPK5N3SGIO5TH6RMT5KBTSQUTHBANCNFSM4T3AJ5YA.

LeoNatan commented 3 years ago

Looking at your code, I don’t think you have.

iTollMouS commented 3 years ago

I damn 😬💔💔.

Thank you.

On Nov 19, 2020, at 5:42 PM, Leo Natan notifications@github.com wrote:



Looking at your code, I don’t think you have.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/LeoNatan/LNPopupUI/issues/4#issuecomment-730419966, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AHXPK5LJZURQM6JHWMEDXA3SQUVF5ANCNFSM4T3AJ5YA.

iTollMouS commented 3 years ago

[cid:46F585C1-8802-4647-B115-6086F324A764-L0-001] [cid:06D6C014-8BBE-4C8F-A9F6-D850C5C308A6]Now I see where this is going ✌️😬😋

Thank you.

On Nov 19, 2020, at 5:42 PM, Leo Natan notifications@github.com wrote:



Looking at your code, I don’t think you have.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/LeoNatan/LNPopupUI/issues/4#issuecomment-730419966, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AHXPK5LJZURQM6JHWMEDXA3SQUVF5ANCNFSM4T3AJ5YA.

LeoNatan commented 3 years ago

Did you get it to work?

iTollMouS commented 3 years ago

Damn right I did . Now I just learned how to customize it .

Customizing is way better and it makes more sense than the default one . ( like music app )

Thank you.

On Nov 19, 2020, at 7:12 PM, Leo Natan notifications@github.com wrote:



Did you get it to work?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/LeoNatan/LNPopupUI/issues/4#issuecomment-730478856, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AHXPK5MDD4NXCW6EW35BFT3SQU7WTANCNFSM4T3AJ5YA.

LeoNatan commented 3 years ago

Enjoy

iTollMouS commented 3 years ago

Will do . [cid:9E8CA71E-F03C-4B37-9FE1-A12DB5DE9D1E]

Thank you.

On Nov 19, 2020, at 8:12 PM, Leo Natan notifications@github.com wrote:



Enjoy

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/LeoNatan/LNPopupUI/issues/4#issuecomment-730515034, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AHXPK5OMXPKRZ7KW7YSQSF3SQVGX5ANCNFSM4T3AJ5YA.