LeoRiether / tori

The frictionless music player for the terminal
https://leoriether.github.io/tori/
GNU General Public License v3.0
27 stars 5 forks source link

tori does not load cava #17

Open LeoRiether opened 1 year ago

LeoRiether commented 1 year ago

@d2rgaming-9000 I'm moving the discussion from #15 here to keep things more organized :) (that issue is related to another implementation of the visualizer that tranzystorek-io is working on)

Is cava properly implemented in Tori yet ? I am finding that the app does not load the visualizer even though I already have cava installed.

It is! But it can be quirky in some cases. Can you play some music on the background, run cava in the terminal and post the results here? Does cava running outside of tori display any errors, or just a blank screen?

Thank you for raising these issues by the way, it helps me make tori more user-friendly :+1:

d2rgaming-9000 commented 1 year ago

Thank you, and thank you, and you're welcome, but thank you.

As for whether cava works or not, sure it does. It even works with Tori. Because it picks the sounds that are coming from alsa/pulse. I have even been configuring cava to make it look more attractive and thematic.

I would like to ask, however, is there a way to configure Tori's code ?

I am saying that because I feel like it can be easier if I can directly inspect rusts code and see if I can get it working.

Looks like cavas main git's repo has already been addressing on how to implement cava in other apps, and I'm sure you have looked at it too.

I really love Tori. I tried musikcube (or musikbox I think?) And hated it, compared to Tori.

The fact that it is terminal based means that it is also lightweight, and more easier to configure it in a way that aligns with the desktop theme.

I am trying to create an OS dotfiles, kind of a small project to be honest, but having almost everything be terminal based is one of my goals I'm trying to reach.

The project I'm working on is still not anywhere close to being ready to be published publicly for everyone to see, but I'm for sure going to include Tori there in the OS.

To paraphrase myself, cava does not work inside Tori, but it works in another instance of another terminal, kind of on its own. And no, cava does not display any errors at all or anything as it works on its own from another instance of another terminal, whereas Tori plays in its own terminal instance (hitting the 'v' button does not activate it either).

I'd would not like it to work you up, however, so I might as well just look at Tori's repo, yours, and inspect the code from there I guess.

Thank you again in advance for your time and consideration. 😇💙

d2rgaming-9000 commented 1 year ago

All in all Tori deserves to be a featured project, and distro tube should take a look at it too !

LeoRiether commented 1 year ago

is there a way to configure Tori's code ?

Currently, you can only configure the playlists directory, mpv's audio output, the visualizer colors and most keybindings, but I'm open to suggestions for additional configurability.

If you want to modify the code, you could clone the repo, make some changes, and run cargo run --release to build and run tori.

cava does not work inside Tori, but it works in another instance of another terminal, kind of on its own

Hm, that's odd. Did you change anything in your cava config to make it work? tori will use exactly this configuration, it does not inherit anything from your personal configuration. If that's not it, I'm not sure I know what could be going wrong here...

mrwormhole commented 1 year ago

I had the same issue, pressing "v" didn't active cava in the tori's terminal

it firstly said to run this modprobe snd_aloop but after that it still can not work with cava